gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test_ed25519 fails if we randomly select index 1 (#22780)

Browse Source 
(cherry picked from commit c1b543c74d)

Co-authored-by: Sean Young <sean@mess.org>
This commit is contained in:
mergify[bot]
2022-01-27 12:50:01 +00:00
committed by GitHub
parent d68a40396c
commit 15e9cedc0d
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
sdk/src/ed25519_instruction.rs
View File

@ -94,6 +94,7 @@ pub fn verify(
let expected_data_size = num_signatures
.saturating_mul(SIGNATURE_OFFSETS_SERIALIZED_SIZE)
.saturating_add(SIGNATURE_OFFSETS_START);
// We do not check or use the byte at data[1]
if data.len() < expected_data_size {
return Err(PrecompileError::InvalidInstructionDataSize);
}
@ -359,7 +360,14 @@ pub mod test {
assert!(tx.verify_precompiles(&feature_set).is_ok());
let index = thread_rng().gen_range(0, instruction.data.len());
let index = loop {
let index = thread_rng().gen_range(0, instruction.data.len());
// byte 1 is not used, so this would not cause the verify to fail
if index != 1 {
break index;
}
};
instruction.data[index] = instruction.data[index].wrapping_add(12);
let tx = Transaction::new_signed_with_payer(
&[instruction],