Better surface bank hash verification failures (#8134)

automerge

runtime/src/accounts.rs

@@ -370,7 +370,12 @@ impl Accounts {
     }
 
     pub fn verify_bank_hash(&self, slot: Slot, ancestors: &HashMap<Slot, usize>) -> bool {
-        self.accounts_db.verify_bank_hash(slot, ancestors).is_ok()
+        if let Err(err) = self.accounts_db.verify_bank_hash(slot, ancestors) {
+            warn!("verify_bank_hash failed: {:?}", err);
+            false
+        } else {
+            true
+        }
     }
 
     pub fn load_by_program(

runtime/src/accounts_db.rs

@@ -1065,6 +1065,10 @@ impl AccountsDB {
             if calculated_hash == found_hash_info.hash {
                 Ok(())
             } else {
+                warn!(
+                    "mismatched bank hash for slot {}: {} (calculated) != {} (expected)",
+                    slot, calculated_hash, found_hash_info.hash
+                );
                 Err(MismatchedBankHash)
             }
         } else {