Error counters for streamer (#658)

* error counters for streamer

* more counters
This commit is contained in:
anatoly yakovenko
2018-07-17 08:20:35 -07:00
committed by GitHub
parent d8c9655128
commit dd0c1ac5b2
2 changed files with 15 additions and 4 deletions

View File

@ -537,6 +537,7 @@ impl Crdt {
) -> Result<()> { ) -> Result<()> {
if broadcast_table.is_empty() { if broadcast_table.is_empty() {
warn!("{:x}:not enough peers in crdt table", me.debug_id()); warn!("{:x}:not enough peers in crdt table", me.debug_id());
inc_new_counter!("crdt-broadcast-not_enough_peers_error", 1, 1);
Err(CrdtError::TooSmall)?; Err(CrdtError::TooSmall)?;
} }
trace!("broadcast nodes {}", broadcast_table.len()); trace!("broadcast nodes {}", broadcast_table.len());
@ -643,7 +644,8 @@ impl Crdt {
.collect(); .collect();
for e in errs { for e in errs {
if let Err(e) = &e { if let Err(e) = &e {
error!("broadcast result {:?}", e); inc_new_counter!("crdt-retransmit-send_to_error", 1, 1);
error!("retransmit result {:?}", e);
} }
e?; e?;
} }

View File

@ -583,7 +583,10 @@ pub fn window(
match e { match e {
Error::RecvTimeoutError(RecvTimeoutError::Disconnected) => break, Error::RecvTimeoutError(RecvTimeoutError::Disconnected) => break,
Error::RecvTimeoutError(RecvTimeoutError::Timeout) => (), Error::RecvTimeoutError(RecvTimeoutError::Timeout) => (),
_ => error!("window error: {:?}", e), _ => {
inc_new_counter!("streamer-window-error", 1, 1);
error!("window error: {:?}", e);
}
} }
} }
let _ = repair_window( let _ = repair_window(
@ -729,7 +732,10 @@ pub fn broadcaster(
Error::RecvTimeoutError(RecvTimeoutError::Disconnected) => break, Error::RecvTimeoutError(RecvTimeoutError::Disconnected) => break,
Error::RecvTimeoutError(RecvTimeoutError::Timeout) => (), Error::RecvTimeoutError(RecvTimeoutError::Timeout) => (),
Error::CrdtError(CrdtError::TooSmall) => (), // TODO: Why are the unit-tests throwing hundreds of these? Error::CrdtError(CrdtError::TooSmall) => (), // TODO: Why are the unit-tests throwing hundreds of these?
_ => error!("broadcaster error: {:?}", e), _ => {
inc_new_counter!("streamer-broadcaster-error", 1, 1);
error!("broadcaster error: {:?}", e);
}
} }
} }
} }
@ -782,7 +788,10 @@ pub fn retransmitter(
match e { match e {
Error::RecvTimeoutError(RecvTimeoutError::Disconnected) => break, Error::RecvTimeoutError(RecvTimeoutError::Disconnected) => break,
Error::RecvTimeoutError(RecvTimeoutError::Timeout) => (), Error::RecvTimeoutError(RecvTimeoutError::Timeout) => (),
_ => error!("retransmitter error: {:?}", e), _ => {
inc_new_counter!("streamer-retransmit-error", 1, 1);
error!("retransmitter error: {:?}", e);
}
} }
} }
} }