Oliver Eyton-Williams
2d7b1255cc
fix: add missing .english extensions ( #38298 )
2020-02-28 07:19:22 -08:00
Kristofer Koishigawa
6cfd0fc503
fix: improve Project Euler descriptions, challenge seeds, and test cases ( #38016 )
...
* fix: improve Project Euler descriptions and test case
Improve formatting of Project Euler test descriptions. Also add poker hands array and new test case for problem 54
* feat: add typeof tests and gave functions proper names for first 100 challenges
* fix: continue fixing test descriptions and adding "before test" sections
* fix: address review comments
* fix: adjust grids in 18 and 67 and fix some text that reference files rather than the given arrays
* fix: implement bug fixes and improvements from review
* fix: remove console.log statements from seed and solution
2020-02-28 06:39:47 -06:00
Randell Dawson
41718abf76
fix(learn): consolidate comments for responsive web design cert ( #38256 )
...
Related to PR #38040
This PR is an attempt to consolidate/remove as many comments in the challenge seed code in the Responsive Web Design certification challenges, to be able to create a small translation lookup object for translating the English comments to other languages.
2020-02-27 20:50:46 +05:30
Harsh Savergaonkar
c21c9f0acb
Added meaning of ones in adjacency matrices ( #37048 )
...
* Added meaning of ones in the matrix
* Apply suggestions from code review
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: add slash to avoid markdown lint error
Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2020-02-27 06:54:11 -06:00
Sanket Kogekar
1a87f1f7c0
add: solution to project euler problem 20 ( #38257 )
...
* add: solution to project euler problem 20
* Update curriculum/challenges/english/08-coding-interview-prep/project-euler/problem-20-factorial-digit-sum.english.md
Accidentally added last line. Calling function is unnecessary in solution.
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* right place for starting braces
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com >
* moved starting brace to previous line.
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Manish Giri <manish.giri.me@gmail.com >
2020-02-26 14:22:40 -05:00
Prakash Kumar
c9d8c2a73c
fix(learn): typo in Serialization of a User Object ( #38262 )
2020-02-26 15:07:32 +05:30
Vincent Shury
b49b9f3e3c
Typo whitespace fix in access-multi-dimensional-arrays-with-indexes.english.md ( #38247 )
...
* Update access-multi-dimensional-arrays-with-indexes.english.md
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2020-02-24 17:02:53 +01:00
Randell Dawson
78156a65f0
fix(curriculum): Added test to Return a Sorted Array Without Changing the Original Array challenge to validate new array is returned ( #38105 )
...
* fix: added test to validate new array is returned
* fix: changed text to reflect changed test
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2020-02-24 15:30:48 +01:00
Tom
a09ffadd5a
fix: responsive image challenge ( #37934 )
...
* fix: responve image challenge
* fix: bad solution
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2020-02-20 22:53:30 +05:30
Oliver Eyton-Williams
b0f1fa4b96
fix: make recursion challenge more intuitive ( #37399 )
2020-02-20 21:36:33 +05:30
Igor Snitkin
dc7092ecd1
(fix learn): Update description to accommodate tests ( #38224 )
2020-02-19 00:13:34 +05:30
lasjorg
9a5ae756ac
fix(challenge): check inline style for color ( #38211 )
...
* fix(challenge): check inline style for color
* Update curriculum/challenges/english/01-responsive-web-design/basic-css/change-the-color-of-text.english.md
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
2020-02-18 23:38:16 +05:30
Oliver Eyton-Williams
f84173866a
fix: make frankenSplice tests more robust ( #38225 )
2020-02-18 21:24:24 +05:30
Prakash Kumar
c730f4aef4
Update hash-and-compare-passwords-synchronously.english.md ( #38226 )
2020-02-18 09:28:38 +01:00
Prayag
701bbc2ae9
added solution to d3 challenge add-labels-to-d3-elements ( #38208 )
2020-02-13 20:59:16 +05:30
kundan kumar
971c62ab53
fix : Unclear test output use-array.map-to-dynamically-render-… ( #38191 )
2020-02-13 02:41:36 +05:30
Hassaan Pasha
2f951f0dff
fix: edited the duplicate test guideline to mirror the actual… ( #38199 )
2020-02-12 20:47:24 +05:30
srdubya
3fd336d3e9
fix(learn): correcting Hash Table Lookup Efficiency ( #38130 )
...
A hash table provide a lookup of O(1), not O(n).
2020-02-12 12:27:47 +05:30
Hassaan Pasha
0498e27902
fix: added white space checks including newlines to ensure pro… ( #38166 )
...
* fix: added white space checks including newlines to ensure proper validation of trim method
* fix: Addressing comments
2020-02-12 12:17:54 +05:30
Ashraf Nazar
5feabd762c
fix: Add tests to check lazy matching is applied and that the string "h1" is not matched ( #38193 )
2020-02-11 10:17:51 -06:00
Hassaan Pasha
80ba943ca3
fix: fixed regex for validating newlines in for loops ( #38180 )
2020-02-09 18:43:43 -06:00
Josh Soref
004b99bf8f
chore: fix typos in spelling ( #38100 )
...
* spelling: accidentally
* spelling: announce
* spelling: assembly
* spelling: avoid
* spelling: backend
* spelling: because
* spelling: claimed
* spelling: candidate
* spelling: certification
* spelling: certified
* spelling: challenge
* spelling: circular
* spelling: it isn't
* spelling: coins
* spelling: combination
* spelling: compliant
* spelling: containers
* spelling: concise
* spelling: deprecated
* spelling: development
* spelling: donor
* spelling: error
* spelling: everything
* spelling: exceed
* spelling: exist
* spelling: falsy
* spelling: faulty
* spelling: forward
* spelling: handle
* spelling: indicates
* spelling: initial
* spelling: integers
* spelling: issealed
* spelling: javascript
* spelling: length
* spelling: maximum
* spelling: minimum
* spelling: mutable
* spelling: notifier
* spelling: coordinate
* spelling: passport
* spelling: perform
* spelling: permuter
* spelling: placeholder
* spelling: progressively
* spelling: semantic
* spelling: submission
* spelling: submit
* spelling: translations
* spelling: turquoise
* spelling: visualization
* spelling: without
* spelling: registration
* spelling: representation
2020-02-08 23:59:10 +05:30
Oliver Eyton-Williams
a7075a579c
Fix: Problem 39: Integer right triangles ( #38145 )
...
* fix: correct test and add solution
I also changed the seed to report the results of an easier example to
the user, since just evaluating the function mostly wastes time.
* fix: use a better solution
* fix: credit original author
2020-02-08 21:09:32 +05:30
Sidtharthan A N
8cf64f2539
ProjectEuler | Update Problem statement of 002 to match projecteuler.net ( #38101 )
...
* Correct ProjectEuler:002 definition and tests
From projecteuler.net:
By considering the terms in the Fibonacci sequence whose values do not exceed four million, find the sum of the even-valued terms.
Correct: take all f(n) where f(n) <= 4,000,000 and f(n) is even
Incorrect: take all f(n) where n <= 4,000,000 and f(n) is even
* Incorporate PR review suggestios to ProjectEuler 002
Reword the problem statement
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2020-02-07 10:09:35 -06:00
Kristofer Koishigawa
4ef445c543
feat: add styles for markdown tables and convert some HTML tables to markdown ( #38126 )
2020-02-07 09:47:35 +01:00
Kiara Barias
afd467f5dc
Removes RSA links from English challenges ( #37869 )
...
* RSA links deleted from challenges
* fix: remove remaining RSA links in challenges
2020-02-07 14:46:07 +09:00
Shubham Shah
bef738f0d4
modfied tests and made correction in solution ( #38023 )
2020-02-06 20:31:03 -05:00
David Lau
f3a386982a
Misspelling fix, add colon. ( #38169 )
2020-02-06 09:46:44 +01:00
Tom Monks
cccad94754
fix(learn): updated challenge text to clarify when to start using new boilerplates ( #38124 )
...
* fix: update to clarify new boilerplates used
Updating challenge text to make it more clear that learners need to switch to new boilerplate
* fix: improved wording to clarify new boilerplates used
Updating challenge text to be consistent and make it clear where learners are to switch to new boilerplate
Incorporating suggestions from PR #38124
2020-02-05 21:15:53 -06:00
Hassaan Pasha
d89eae392f
fix: adding test to check if flat or flatMap method was used in the steamroller challenge ( #38158 )
...
* fix: adding test to check if flat or flatMap method was used in the steamroller challenge
* Addressed comments and acknowledged suggestions
2020-02-04 17:00:33 -05:00
PHILIP OBIORAH
66e5cf0051
fix(curriclum): modified add images to your website ( #38155 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Manish Giri <manish.giri.me@gmail.com >
2020-02-04 20:12:53 +05:30
Nick Black
6a4b42c4ec
Update to make instructions more clear ( #38068 )
...
The instructions on the exercise following this specify 'behind the scenes' which sounds more clear than 'in the background'.
2020-02-04 10:54:02 +03:00
Obba Paschal
8b692560e8
Fix: (Rosetta-Code) Correct the Test suite and make expression clearer ( #38102 )
...
* Fix: Correct the Test suite and make expression clearer
* Update 24-game.english.md
2020-02-04 07:08:32 +05:30
rsapkf
cfbb3f64c4
Change variable declaration from var
to let
in description ( #38150 )
2020-02-02 15:29:03 -06:00
Dylan Cutler
15d5824795
Change n pounds to n pence in Project Euler problem 31 ( #38144 )
2020-01-31 15:23:15 +01:00
Randell Dawson
2f39dd07d6
fix: removed part of user story
2020-01-29 14:05:39 +09:00
Ezekiel Oladejo
7453131461
Apply proper formatting on Note paragraph ( #38120 )
2020-01-26 17:31:51 -06:00
Ashraf Nazar
fda7fb174e
fix: Correct paths in English exercises by prefixing "/" before "learn" ( #38099 )
...
* fix: Correct paths in English exercises by prefixing "/" before "learn"
* fix(lang): Correct paths to exercises by prefixing "/" before "learn" in remaining languages
2020-01-26 12:51:21 -06:00
Ashraf Nazar
1159a8dcaf
fix: Add edge case for mixed grouping of characters exercise, where "Frank Roosevelt" returns false ( #38097 )
2020-01-22 15:58:47 +05:30
Bojan Cvjetkovic
10bd00309a
Added solution to this exercise ( #38074 )
...
* Added solution to this exercise
* fix: changed js to html
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-01-22 00:00:06 +05:30
Perrottarichard
bc470325d0
Update use-destructuring-assignment-with-the-rest-parameter-to-reassign-array-elements.english.md ( #38092 )
...
I added 'the' to correct the English grammar and hence improve the readability of the instructions.
2020-01-21 08:25:10 -06:00
Nick Black
c408cb9c1a
Removed typo from Instructions ( #38066 )
...
* Removed typo from Instructions
Removed the word 'with' which doesn't belong.
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/quality-assurance-and-testing-with-chai/run-functional-tests-on-api-endpoints-using-chai-http.english.md
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/quality-assurance-and-testing-with-chai/run-functional-tests-on-api-endpoints-using-chai-http.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-01-15 08:18:58 +05:30
ML
d824c77012
Move the comment on line 71 to its own line ( #38036 )
...
* Move the comment on line 71 to its own line
The comment "use function argument destructuring" was on the same line as some code, and when displayed as a challenge it returned to a new line and was not commented out.
* Update line 71 comment per @manish-giri suggestion
Move the comment "use function argument destructuring" to above the "change code below this line" comment for clarity. Based on conversation in this pull request https://github.com/freeCodeCamp/freeCodeCamp/pull/38036
2020-01-15 08:17:34 +05:30
Nick Black
27b4deae36
Update run-functional-tests-on-api-endpoints-using-chai-http-ii.english.md ( #38065 )
...
Corrected typos.
2020-01-14 21:18:17 +05:30
Prakash Kumar
e925e854f1
Update delete-one-document-using-model.findbyidandremove.english.md ( #38041 )
2020-01-11 07:10:51 -08:00
M B
7f6a653c28
fix: update react lesson link (remove 404) ( #38031 )
...
* Update lesson link (remove 404)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-01-09 17:29:50 +01:00
Ronald van der Bergh
fd36d6db37
fixed typo, "is" changed to "in" ( #38032 )
2020-01-08 18:58:31 -08:00
Tom
86127a24f7
fix: add tests for header parser microservice project ( #37187 )
...
* fix: add tests for header parser microservice project
* fix: make test more robust
* fix: make text use 'should'
2020-01-08 12:31:19 -08:00
TAKAHASHI Shuuji
e65c47c6ba
fix: Wrap codes with <code> tags in css-flexbox challenge. ( #38025 )
2020-01-08 15:18:48 +03:00
Randell Dawson
a70e15c0a7
fix: allow-space-in-destructuring-regex ( #37997 )
2020-01-07 17:22:15 +01:00