gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
30,233 Commits 9 Branches 0 Tags
main
Commit Graph

1727 Commits

Author SHA1 Message Date
TAKAHASHI Shuuji
81fe7678c1 Wrap column with <code> tags. (#38020) 2020-01-07 14:15:03 +01:00
Randell Dawson
6809578044 fix: change starting font-size (#37981) 2020-01-07 13:39:06 +03:00
Andree Amaro Gonzalez
0a0cbead58 fix(learn): Fixed tests for the create a hash table challenge (#37870) 
* fix: update create hash table's tests

* fix: update the way lookup method is declared to enable the use of this.collection in it
 2020-01-03 11:18:40 +01:00
Oliver Eyton-Williams
e4a229187e fix: speed up tests 
Either improved the algorithm or reduced the difficulty for the slowest
tests. All these pass with testProtectTimeout = 500, so should be safe
on most machines with the current timeout of 2500.
 2020-01-03 11:41:52 +05:30
Tom
1b06bb29f0 fix: allow g flag on regex (#37941) 2020-01-02 18:24:07 -07:00
Tom
0adfc79c7a fix: fixed position challenge (#37945) 2020-01-02 17:41:36 -07:00
Rohit Ambre
fe1c6b24ab Added href to empty <a> tag in social auth implementation II (#38002) 
* Added href to empty <a> tag in social auth implementation II

* corrected typos in authentication with socketIO challenge

* corrected typo as suggested

Co-Authored-By: Eric Leung <eric@erictleung.com>

Co-authored-by: Eric Leung <eric@erictleung.com>
 2020-01-02 17:36:15 -07:00
Nikolas Broman
d07c85151b Fix typo (remove duplicate word 'should') (#37998) 2019-12-31 08:50:46 -08:00
Randell Dawson
1f98af5841 fix: used assert.deepEqual to compare arrays (#37959) 2019-12-31 13:33:04 +05:30
Shubham Shah
3cc0395964 added a test to challenge:falsy-bouncer (#37973) 
* added a test to challenge:falsy-bouncer

* modified tests of challenge:falsy-bouncer
 2019-12-29 17:17:17 -06:00
Gregory Gubarev
8bd2fb8bc5 fix(i18n): delete duplicate text in test desc (#37975) 2019-12-23 20:47:10 +05:30
Oliver Eyton-Williams
e5abfa15ad Revert "fix: stop user code after 100ms of execution" (#37965) 
This reverts commit 01b37f664f.
 2019-12-21 11:09:32 +05:30
Oliver Eyton-Williams
01b37f664f fix: stop user code after 100ms of execution (#37841) 
Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
 2019-12-20 19:28:17 +05:30
Randell Dawson
5609a1303e fix: corrected tests for 3 challenges (#37948) 2019-12-19 11:26:50 +01:00
lasjorg
8cca639450 fix(challenge): check inline styles on elements, add solution (#37756) 2019-12-16 16:18:29 +01:00
Sean Coleman
203c9823e8 Fixed minor grammar issue in escape-sequences-in-strings.english.md (#37940) 
* Update escape-sequences-in-strings.english.md

Fixed minor grammar issue in list item 1 of the description section.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2019-12-16 06:16:16 -08:00
Arthur
616d96f612 refactor: update trivial regex capture group find and replace challenge (#37768) 
* refactor: replace trivial regex capture group challenge

Previous challenge could be completed without any capture groups. New
challenge requires 3 capture groups and 3 uses of the submatches in the
replacement.

resolves #17645

* test: validate at least 3 capture groups were used

Use solution from SO
(https://stackoverflow.com/questions/16046620/regex-to-count-the-number-of-capturing-groups-in-a-regex)
as suggested by @RandellDawson to count the number of capturing
groups, regardless of whether or not the regex in question solves the
broader problem.

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* refactor: more meaningful variable name

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* test: add parenthesized substring test

* test: ensure 3 uses of substring replacement

* refactor: reword instructions

* fix: minor grammar fix

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* refactor: elaborate wording in test
 2019-12-14 16:41:47 -05:00
John A Maloney
c935d21f84 Fixed bad capture group in regex (#37575) 2019-12-13 22:16:30 -06:00
Randell Dawson
85e7fe45d5 fix(curriculum): use object.assign to prevent overwriting prototypes if user uses class instead of function (#37648) 
* fix: use object.assign to prevent overwriting when using class

* fix: remove non-used isBinarySearchTree method
 2019-12-13 15:04:05 -06:00
lasjorg
63b9be8faf fix(challenge): account for browser zoom, add note to challenge (for width challenge) (#37688) 
* fix(challenge): account for browser zoom, add note to challenge

* fix(challenge): use regex for width assert

* fix(challenge): remove note

* fix(challenge): revert to initial PR code

* updated regex, add check for maxWidth
 2019-12-13 07:05:23 -08:00
classicmatsuo
33cec6b6f2 fix: updated instructions for install-and-set-up-mongoose (#37908) 
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Kevin Matsuo <kmatsuo@ARDs-MacBook-Pro-2.local>
 2019-12-13 16:23:11 +05:30
Randell Dawson
44ff327a38 fix(curriculum): make test more flexible for (#37902) 
* make test more robust

* fix: changed test to ignore extra spaces in html

* Revert "make test more robust"

This reverts commit 89718eb5e5.
 2019-12-11 23:20:19 -05:00
Randell Dawson
cb3524ee31 fix: simplify challenge testString (#37826) 2019-12-07 15:47:08 -05:00
Randell Dawson
623c08cbfa fix: removed semi-colon from regex (#37881) 2019-12-07 15:02:42 -05:00
Christoph Deil
dc5c0c7f82 Fix minor grammar issue in override-styles-in-subsequent-css.english.md (#37871) 2019-12-04 14:32:55 -08:00
Waldo Luis Ribeiro
8af54eb272 fix(curriculum): Technical language correction (#37812) 
Technically, the prototype is not cloned; it is merely referenced.
 2019-12-04 21:01:49 +00:00
Randell Dawson
984a530905 fix(curriculum): added extra mongoose options to prevent log warnings (#37693) 
* fix: added extra mongoose options to prevent log warnings
 2019-12-03 13:12:27 +09:00
Randell Dawson
dd2fb28ee0 fix: make tests more robust (#37830) 2019-12-02 18:42:32 -05:00
Randell Dawson
a68e3ef39d fix: change rating to ratings (#37863) 2019-12-02 17:25:11 -05:00
Randell Dawson
7454719334 fix(curriculum): Improved Use Recursion to Create a Countdown challenge (#37548) 
* fix: improved recursive challenge

* fix: rewording of two challenges

* fix: add code tags

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-12-02 17:58:07 +01:00
Randell Dawson
a6766127cc fix(curriculum): corrected test and added solution for Create a Hash table challenge (#37582) 
* fix: corrected test and added solution

* fix: redefine hash

* fix: use defined hash

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2019-12-02 17:23:56 +01:00
Randell Dawson
d39dd970b6 fix(curriculum): use regex to avoid differences in how browsers calculate style property values for Decrease Opacity of an Element challenge (#37838) 
* fix: use regex to avoid diff in browsers

* fix: improve regex
 2019-12-02 20:50:34 +05:30
Tom
9866d2f241 fix: grid column and grid row tests (#37736) 
* fix: grid column and grid row tests

* fix: test text verbiage

* fix: add solution to pass build error

* fix: make test more readable
 2019-12-01 10:02:24 +05:30
Randell Dawson
aac1c58374 fix(curriculum): make last test more robust for Uncomment HTML challenge (#37843) 
* fix: correct last test

* fix: remove forgotten console.log

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-11-30 23:09:48 -05:00
Randell Dawson
58ca8ddf2a fix: correct function name in test text (#37839) 2019-11-30 18:30:10 -05:00
Tom
da99033b77 fix: sum all primes description (#37750) 
* fix: sum all primes description

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2019-11-30 16:33:37 -06:00
Wocanilo
cabfd25b40 MODIFIED convert-json-data-to-html to warn about XSS attacks (english) (#37036) 
*  MODIFIED convert-json-data-to-html to warn about XSS attacks (english)

* Forgotten newline in convert-json-data-to-html

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: suggested changes

* fix: added commas
 2019-11-30 12:52:59 -06:00
Tim dinia
c331b12413 fix(curriculum): correct typo in nest one array within another array challenge instruction (#37851) 2019-11-29 10:07:51 +01:00
Randell Dawson
08bbd893d3 fix: switched order of first two bst challenges (#37675) 2019-11-27 12:12:58 +01:00
Randell Dawson
2c15bcbb43 fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures (#37761) 
* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-11-27 11:57:38 +01:00
Randell Dawson
b7949087e3 fix(curriculum): Improve verbiage and add examples to the map, filter, and reduce challenges (#37709) 
* fix: improve verbiage and add examples to challenges

* fix: condensed map method wording

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: remove leading space

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: improved verbiage

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: shortened reduce challenge verbiage

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: shorten verbiage related to reduce 2nd parameter

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added comma

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: shortened filter verbiage

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix; added comma

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: improved verbiage of map method

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: shortened reduce verbiage

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: correct map method verbiage

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added word array

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added missing comma

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: changed u to sumOfAges

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: created one sentence out of many

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: changed to on each iteration

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: fixed verbiage in filter and map challenges
 2019-11-27 07:33:09 +05:30
Stryyder
58444af093 very minor grammar fix (#37840) 2019-11-26 15:53:18 -08:00
Randell Dawson
ba415184f6 fix(curriculum): simplify the Remove Items Using splice() challenge without using reduce (#37829) 
* fix: simplify challenge without using reduce

* fix: prevent user from adding new elements to sum to 10

* fix:  add from

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
 2019-11-26 15:14:44 -05:00
lasjorg
ba927090fe fix(challenge): account for browser zoom, add note to challenge (for height challenge) (#37687) 
* fix(challenge): account for browser zoom, add note to challenge

* fix(challenge): use regex for height assert

* fix(challenge): remove note

* fix(challenge): revert to initial PR code
 2019-11-25 19:40:21 -08:00
Randell Dawson
98bb2c1085 fix: added new test case to prevent invalid regex (#37769) 2019-11-25 20:25:24 -05:00
Kiara Barias
c1b3588e59 Basic JS challenge: use-prototype-properties link added (#37802) 
* Update use-prototype-properties-to-reduce-duplicate-code.english.md

* Update use-prototype-properties-to-reduce-duplicate-code.english.md
 2019-11-25 13:02:21 -06:00
Randell Dawson
4fbe02abba fix(curriculum): Added necessary variable declarations for JSON APIs and Ajax challenges (#37535) 
* fix: added necessary variable declarations

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: deleted unnecessary file

* fix: corrected some spacing

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: indented code sections
 2019-11-25 12:21:17 -06:00
mikemorr
62e1464eb7 change "given" to "adding" (Was: change "given" to "giving") (#37823) 
* change "given" to "giving"

* change to "adding" as suggested

As suggested in https://github.com/freeCodeCamp/freeCodeCamp/pull/37823
 2019-11-25 08:14:08 -08:00
Divyanshu
a987245e18 Added new test cases and corrected the solution for positive and negative lookahead for ensuring that strings beginning with numbers are not accepted (#37485) 
* Added new test case '8pass99' for positive and negative lookahead

* Changed the pwRegex to reflect the new solution

* Updated the pwRegex to reflect the latest solution as on forum

* Added another test case to catch "/^(?=\w{6,})(?=\D*\d{2})/" solution
 2019-11-24 17:11:20 -05:00
Waldo Luis Ribeiro
deb24f77b6 fix(curriculum): English editing (#37814) 
* fix(curriculum): English editing

* fix(curriculum): English editing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* Update use-class-syntax-to-define-a-constructor-function.english.md
 2019-11-24 16:38:30 -05:00