Commit Graph

1686 Commits

Author SHA1 Message Date
Berkeley Martinez
063d16383f Fix Change editor.match to code.match to prevent collisions 2015-12-02 11:50:45 -08:00
Logan Tegman
7cdf1ef2dd Fix Assert messages missing prepended message: 2015-12-02 10:11:06 -08:00
Rex Schrader
623d8b7c11 Merge pull request #4899 from DDaems/Fix/bonfire-where-art-thou
Fix: bonfire-where-are-thou
2015-12-02 08:29:57 -08:00
Dieter Daems
0bfdbbb28f Capatilize 'Q' in jquery (step 13)
#4906
2015-12-02 08:45:57 +01:00
Dieter Daems
5dcd743b80 Add a additional test, to make it a bit more difficult to use string comparison to pass the tests.
At the moment the provided code will pass the test:

collection.map(function(obj){
      if(JSON.stringify(obj).includes(JSON.stringify(source).replace(/[{}]/g, ''))) arr.push(obj)
})
2015-12-02 06:20:31 +01:00
Arsen Melikyan
9c35002a7b Merge pull request #4861 from justinian336/Add/ES-translation-of-basejumps
Add ES translation of basejumps
2015-12-02 07:49:40 +04:00
Rex Schrader
116252917a Merge pull request #4880 from ltegman/fix/construct-javascript-objects-seed
Fix Construct Javascript Objects Seed
2015-12-01 19:32:58 -08:00
justinian336
22e49f6f4e Add ES translation of basejumps 2015-12-02 02:20:51 +00:00
Logan Tegman
7ce79d67f1 Merge pull request #4783 from justinian336/Add/ES-translation-of-testing-and-debugging
Add ES translation of Testing and Debugging
2015-12-01 17:05:52 -08:00
Logan Tegman
2ddee56301 Fix Construct Javascript Objects Seed 2015-12-01 15:44:09 -08:00
Logan Tegman
e2ec4cb3e6 Merge pull request #4770 from justinian336/Add/ES-translation-of-bootstrap-waypoints
Add ES translation of Bootstrap Waypoints
2015-12-01 15:15:03 -08:00
Logan Tegman
eba5ddb452 Merge pull request #4649 from Oxyrus/patch-1
Add Spanish translation
2015-12-01 15:14:04 -08:00
Logan Tegman
f96d3f08cc Merge pull request #4617 from vtamara/add/ES-basic-javascript
Translation to spanish of basic-javascript.
2015-12-01 15:13:28 -08:00
BKinahan
09537ba2c1 Add closing parenthesis to second test code
Fixes #4858
2015-12-01 22:22:06 +00:00
Logan Tegman
aa5e699b10 Fix WP Manipulate Arrays with Shift Example Code 2015-12-01 10:30:07 -08:00
Arsen Melikyan
f9cd2b341a Merge pull request #4818 from ltegman/fix/wp-typeof-tests
Fix Waypoint Typeof Tests
2015-12-01 21:18:20 +04:00
Arsen Melikyan
2f2e021e03 Merge pull request #4846 from gasperno/fix/test-waypoint-image-link
Improve test case for waypoint:Turn an Image into a Link
2015-12-01 21:11:32 +04:00
Arsen Melikyan
d77f4eab06 Fix a test and add periods 2015-12-01 15:49:14 +04:00
Harsha
d8143ba7e8 Improve test case for waypoint:Turn an Image into a Link 2015-12-01 02:06:12 -05:00
Logan Tegman
140b8e46f4 Fix Waypoint Typeof Tests 2015-11-30 12:59:34 -08:00
Logan Tegman
92c44e0520 Merge pull request #4815 from erictleung/fix/space-consistency
Add space after `while` statement for consistency
2015-11-30 11:11:02 -08:00
Eric Leung
d865716cf1 Add space after while statement for consistency 2015-11-30 11:07:21 -08:00
Eric Leung
56336c1bd1 Add code tags to the word 'size' in Chunky Monkey 2015-11-30 11:00:26 -08:00
justinian336
57c4c95829 Add ES translation of testing and debugging. Thanks to @JS-Taiyou and @vtamara for the corrections 2015-11-30 14:22:57 +00:00
Allister
3ac5ea40f5 Removing sentence, Fixes #4791 2015-11-30 19:36:49 +07:00
Logan Tegman
d210044b6b Fix Misleading BF Test Messages 2015-11-29 19:46:44 -08:00
Berkeley Martinez
4a7470f658 Keywords are not function calls 2015-11-29 16:28:32 -08:00
chriscampbell32
d99be4b44e added that this does not work in safari.
added that this does not work in safari in description

added period.
2015-11-29 14:58:35 -05:00
justinian336
2106da6890 Add ES translation of bootstrap waypoints. Thanks to @vtamara for the revision 2015-11-29 15:26:21 +00:00
Vladimir Tamara
411b90d4ee Translation of basic-javascript. Closes #4542. Thanks for corrections to @justinian336 and for checking to @Oxyrus 2015-11-29 08:35:55 -05:00
Logan Tegman
8bab9c627e Fix Waypoint Add Font Awesome Icons Tests
Closes #4769
2015-11-28 22:57:18 -08:00
Logan Tegman
8284a0054f Merge pull request #4738 from AryanJ-NYC/fix/truncate-a-string-description
Corrected description of Truncate a String bonfire.
2015-11-28 09:42:01 -08:00
Aryan Jabbari
af5a3e088f Corrected description of Truncate a String bonfire.
Close #4706
2015-11-28 12:23:23 -05:00
Andrés
ebe6412e1a Add Spanish translation 2015-11-28 10:33:12 -05:00
Blauelf
98d2322da9 Added a test case to Where do I belong with return value 0
On the chat today I have seen several solutions that cannot return 0 (usually return arr.length instead), and they still pass, as there is no such test case. Here is one, `where([3, 10, 5], 3) === 0`.
2015-11-28 14:37:25 +01:00
sycrat
fdbcce7277 added alt-text in waypoint seeds after it is taught 2015-11-28 16:07:57 +10:00
Eric Leung
341cd1461b Fix display of Roman numeral tests 2015-11-27 21:22:54 -08:00
Rex Schrader
ffd3a926aa Merge pull request #4749 from erictleung/fix/random-number-test-check
Random Whole Numbers - Add test to check for editing of first line of code
2015-11-27 19:24:29 -08:00
Eric Leung
5976fa5ee0 Add test to check for editing of first line of code 2015-11-27 18:29:13 -08:00
Juan Martínez
d3e7f75671 Fixes description on bonfire Check for Palindromes
Closes  #4734
2015-11-27 21:03:00 -04:30
Eric Leung
eda2334743 Fix example code on filter method to avoid confusion 2015-11-26 18:02:37 -08:00
Christian Ipanaque
19c291f2a4 Fixes Math.random() description in waypoint
Fixes the description of Math.random() in Javascript waypoint.

Math.random() generates a random decimal number between 0 and 1.

Closes #4728
2015-11-26 06:03:11 -08:00
Rex Schrader
857f8fd3ef Merge pull request #4704 from erictleung/fix/decimal-and-hexadecimal-description
Fix description explaining hexadecimal numbers
2015-11-26 01:06:26 -08:00
Logan Tegman
a0ffaa6ca4 Merge pull request #4726 from erictleung/fix/change-potential-confusion-on-conditionals
Fix example if-else statements with clearer example
2015-11-26 00:09:56 -08:00
Eric Leung
9c3e43e190 Fix example if-else statements with clearer example 2015-11-26 00:04:10 -08:00
Eric Leung
8cfd2eb114 Add note about how jQuery is zero-indexed for clarification 2015-11-25 20:39:02 -08:00
Logan Tegman
5afd061b90 Merge pull request #4724 from SaintPeter/fix/jquery-comments-to-clarify
Fixes "Use Comments to Clarify Code" Ambiguity
2015-11-25 17:31:05 -08:00
SaintPeter
2a29d8e1f0 Fixes comments top of code ambiguity 2015-11-25 17:26:22 -08:00
Logan Tegman
eff3fc9ff7 Merge pull request #4723 from dcsmith926/staging
use of ".map()" should be ".forEach()"
2015-11-25 17:11:18 -08:00
dcsmith926
1584485739 use of ".map()" should be ".forEach()"
In "seed/challenges/json-apis-and-ajax.json", the use of ".map()" in the 5th and 6th challenges doesn't make sense -- we're not creating a new array by modifying each element of the response, and in challenge 4, the learner was told to use ".forEach()". Seeing ".map()" instead for no apparent reason would likely be a source of confusion.
2015-11-25 18:38:19 -05:00