24781 Commits

Author SHA1 Message Date
mrugesh
a2c5e2379e
docs: update instructions for modifying hint topics (#36842) 2019-09-25 01:25:58 +05:30
Oliver Eyton-Williams
95fdb74d95 feat: escape prevents automatic editor focus 2019-09-24 22:22:14 +05:30
moT01
a7c42446be fix: remove command from hotkeys 2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams
6f5b22fd21 fix: re-remove Side-Panel 2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams
8b2f96609d fix: improve cross-platform consistency
Co-authored-by: moT01 <tmondloch01@gmail.com>
2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams
cd3ef998a6 fix: rollback react-hotkeys and remove buttons 2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams
465f206a9d fix: focus on HotKeys by default 2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams
023df09289 fix: use GlobalHotKeys to catch keyup events
Added GlobalHotKeys just to make sure all keyup events are registered,
regardless of what state HotKeys is in.

Co-authored-by: moT01 <tmondloch01@gmail.com>
2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams
af1008f4e5 fix: wrap backend and project in Hotkeys
Co-authored-by: moT01 <tmondloch01@gmail.com>
2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams
c91393d737 feat: use local HotKeys and allow editor escape
GlobalHotKeys were abandoned, because they were capturing events that
had called stopPropagation.  This meant that something needed to be in
focus, hence passing a ref of the HotKey DOM element to the Editor.

react-hotkeys has been updated to 2.0.0-pre9, because 2.0.0 captured
ctrl keypresses when asked for ctrl+enter

Currently only classic challenges can be executed by hotkey, but all
allow hotkey navigation
2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams
ab3a9076d9 fix: change hotkeys to work across platforms
Co-authored-by: moT01 <tmondloch01@gmail.com>
2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams
a19ceeffe2 feat: add navigation hotkeys 2019-09-24 22:22:14 +05:30
SomeDer
5de58ad98d fix(curriculum): use function form of this.setState (#36623)
* Fix solution

* Update description

* Add test for this.setState function syntax

* Update toggle element instructions

* Fix simple-counter solutions

* Fix bind-this challenge seed and solution

* Fix && challenge seed and solution

* Fix ternary challenge seed and solution

* Use the function form -> Pass a function

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Mention "passing a function" instead of "alternative form"

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Rephrase explanation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* clarify why functions should be used

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Improve tests

* Fix \s escaping in []

* Improve regex

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add test for `this`

* Use block code

* Update bind-this challenge

* Fix last part of instructions

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-09-24 08:12:50 -07:00
Ent Wickler
d08f009bd1 fix(curriculum): Add tests for setter, getter and setting a temperature (es6 tests) (#36620)
* add testing for setter, getter and setting a temperature according to some of feedbacks into the issues 17403

* bugfix: temperature is not a function
2019-09-23 17:13:32 +02:00
mrugesh
e54a7fb350 fix(client): merge and update the learn map (#36822) 2019-09-21 16:39:48 +03:00
mrugesh
a5b176be88
docs: update contributing guides (#36816) 2019-09-20 23:56:56 +05:30
Oliver Eyton-Williams
0c68f6a605 fix: improve map responsiveness (#36827)
* fix: improve map responsiveness

* fix: update SuperBlock tests
2019-09-20 23:52:03 +05:30
Oliver Eyton-Williams
3a0cd56ad3 fix(curriculum): Add and modify tests to catch bad code. (#36429) 2019-09-20 09:28:50 -07:00
Parth Parth
8c921a05d6 feat: add top five company logos (#36812) 2019-09-19 22:24:08 +05:30
Ahmad Abdolsaheb
e653235d94 feat: universal navbar (#36744)
* feat: add universal nav

* fix: add portfolio redirect
2019-09-19 22:15:01 +05:30
sybiljasmine
5d946f3d77 valid factorial number update under the tests (#36792)
* valid factorial number update under the tests

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Removed redundant array in the tests
2019-09-19 08:52:09 -07:00
Oliver Eyton-Williams
c483940da0 fix: stop Editor competing with Modal for focus
Editor now checks if the modal is open before trying to obtain focus.
2019-09-19 17:47:02 +05:30
Randell Dawson
1dd13a5865 docs: update how to work on guide articles on forum
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2019-09-19 16:21:27 +05:30
Kaitlin
76e1b1a4ba Update user test 13 desc to match changed test (#36523)
* Update user test 13 desc to match changed test

Refer https://github.com/freeCodeCamp/testable-projects-fcc/issues/933.

* Add examples to illustrate change to user story 13
2019-09-19 17:51:10 +09:00
mrugesh
5d92b3c668 fix: project views and icons for intros (#36811) 2019-09-19 10:14:58 +03:00
Ezgi Kaysı Kesler
93360f4e01 fix:Typo in uncomment-html page (#36800)
* fix:Typo in uncomment-html page

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/uncomment-html.english.md

removed comma

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-09-18 10:51:55 -07:00
mrugesh
44216f231a
docs: update readme 2019-09-18 17:26:49 +05:30
Valeriy S
12f65a6742 fix(curriculum): fix challenges for russian language 2019-09-18 12:05:38 +05:30
Valeriy
a17c3c44aa fix: recreate translated challenges 2019-09-18 12:05:38 +05:30
mrugesh
6237f189ba
docs: update readme table 2019-09-16 12:23:05 +05:30
Ahmad Abdolsaheb
0f3e248b5b fix: clean up old views (#36778)
* fix: clean up

* fix: redirect /software-resources-for-nonprofits

* fix: update snap and redirect
2019-09-15 13:06:11 +05:30
Anna Emmanuel
665f0c6a2e Spelling corrected (#36789) 2019-09-13 13:58:41 -07:00
Jasper Pilgrim
191f915e94 fix(curriculum): grammar, add period (#36785) 2019-09-12 18:48:28 +05:30
Mrugesh Mohapatra
39aa707533 revert: "fix: make night mode default for code blocks"
This reverts commit 5a38887af1d7e0d9083ad127c8acf461038de8ab.
2019-09-11 23:20:01 +05:30
Mrugesh Mohapatra
b40e069724 revert: "fix: ensure 'night' is set before hydration"
This reverts commit 18bee1bd59241e683836456afa48d2aa1a221f1a.
2019-09-11 23:20:01 +05:30
mrugesh
31947c5009
fix(server): update email template copy (#36780) 2019-09-11 18:58:41 +05:30
Huyen Nguyen
087640d020 fix(curriculum): Make challenge instruction clearer (#36771) 2019-09-11 14:18:28 +05:30
Bouncey
53ca86e953 Fix: Ensure emails are processed in lower-case 2019-09-10 11:02:22 +05:30
Bouncey
e08bc32170 Fix: migrate from DeprecationWarning over Buffer security concerns 2019-09-10 11:02:22 +05:30
Bouncey
7271e82503 Fix: Restore email change functionality 2019-09-10 11:02:22 +05:30
Yuji Ueki
41c9ff4cb4 docs: add Japanese translation of README.md 2019-09-09 16:15:24 +05:30
Yuji Ueki
49d27afacc docs: fix link path to other translations (#36767) 2019-09-08 10:10:40 +05:30
Tom
338234d635 fix: make donate modal scrollable (#36761)
* fix: make donate modal scrollable

* fix: make text more readable on donate modal


Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2019-09-07 03:19:56 +05:30
Tom
2b9d2605c5 fix(style): remove margin on certifications (#36755) 2019-09-06 14:59:39 +05:30
Tom
40b6b68178 fix(style): rework color scheme for icons (#36760)
* fix(style): rework color scheme for icons

* fix: update snapshot

* fix(style): add some space in and around test area

* fix(style): lessen padding
2019-09-06 14:56:08 +05:30
arun-sharma-blr
418a1061dd fix: added a microservices section (#32799)
Added a quick introduction to microservices
2019-09-04 19:36:16 +05:30
Valeriy
9ce4331e25 fix(client): set --header-height only if Header exists 2019-09-04 19:00:57 +05:30
Valeriy
d161459109 feat(client): show loader if editor takes a long time to load 2019-09-04 18:56:08 +05:30
Valeriy
aaf7ed7357 fix(client): adjust splitters styles 2019-09-04 18:56:07 +05:30
Valeriy
4ef44a4621 chore(client): update monaco-editor 2019-09-04 18:56:06 +05:30