25029 Commits

Author SHA1 Message Date
Marco Valero
f3ee4f85ae Changes to "access-array-data-with-indexes.english" challenge description (#37730)
* edited description to be a little more clear on how to access elements in an array through indeces

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-array-data-with-indexes.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-10 15:53:05 -05:00
jotagarciaz
84d683940a docs: improving spanish translations (#37593) 2019-11-10 10:42:27 -08:00
Eunjeong Park
fb551cb23c Improve Korean translation and change wording (#36973)
* Fix typo in CONTRIBUTING.md

Remove spacebar and enable markdown

* Retranslate CONTRIBUTING.md in Korean

- Retranslate CONTRIBUTING.md (updated version) in Korean
- Correct an error in translation
- Make expressions more clear and friendly

* Change wording to more friendly one
2019-11-10 04:34:58 -08:00
Tristan Michael Lawrence
5296d5c731 fix: removed trailing spaces, fixed a typo (#37572)
* removed trailing spaces, fixed a typo

* removed trailing spaces from basic-css challenges
2019-11-10 04:33:10 -08:00
anthonyjvoss
7639306a20 doc: improved readability and added port validation (#37614)
Provided updates for better overall readability.  Added a section for validating whether port 3000 is already in use on Windows and MacOS.
2019-11-10 04:29:30 -08:00
Loic Beylot
c5098e9fc9 docs: fix a few typos in French guidelines (#37628)
* Fix a few typos

One missing s for a plural word and a few missing spaces.

* Fix one typo
2019-11-10 04:27:33 -08:00
jasonranney
26e857b6ab fix: update JavaScript capitalization (#37466) 2019-11-10 04:24:34 -08:00
lasjorg
e1a1ed5c12 fix(client): use JSON.stringify replacer function for NaN (#37684) 2019-11-10 04:17:18 -08:00
Kirankumar Ambati
32954923e1 fix: Read-Search-Ask link on Frontend-Libraries projects (#37710) 2019-11-10 04:16:18 -08:00
Daniel Veazey
9e1b2b7401 fix(curriculum) correct "an" to "a" (#37726)
* replace the word "dashes" with "hyphens"

* correct "an" to "a"
2019-11-09 18:13:10 -05:00
Mrugesh Mohapatra
8107106915 fix(donate): quick patch for auth 2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra
139f8fcb1b chore: remove poweredByStripe asset 2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra
4cd5542489 feat(donate): two col layout checkout page 2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra
7a4e84d163 chore(donate): remove donate page tests
Removed the donate page tests, which seemed weirdly depending on
the rendered tree. Unreliable at the best.

We sould be adding comprehensive tests to the components instead.
2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra
83ac3c5f95 chore(donate): remove unused donate modal wiring
This commit removed the donate modal and related wiring,
although some of the state mapping is still around.

The remaining state mapping can either be removed, or kept
for now, because it will be replaced as is for the newer
motivation based donation prompts
2019-11-09 11:39:29 -08:00
imgbot[bot]
a36e0d8351 [ImgBot] Optimize images (#37723)
*Total -- 50.98kb -> 38.49kb (24.51%)

/client/src/assets/images/square_puck.png -- 25.51kb -> 13.31kb (47.81%)
/client/src/assets/images/freeCodeCamp-404.svg -- 25.47kb -> 25.17kb (1.17%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
2019-11-09 01:33:48 -08:00
Ahmad Abdolsaheb
ccd135f268 feat: update logo (#37716)
* feat: update logo

* fix: adjust logo height
2019-11-09 01:31:49 -08:00
David Carlson
bdae7343bb escaped backslash character on line 22 (#37721)
Previously only showed empty parentheses.
2019-11-08 23:25:48 -05:00
David Carlson
00914be3e8 Removed text about prior knowledge (#37722)
This section is now after Basic Javascript, but the challenge indicates that "function" and "return" are unknown at this point. Simply a product of an (apparent?) move.
2019-11-08 22:03:44 -05:00
Abdelrahman Ashraf
94532f98db refactor(tests): enzyme => react-testing-library (#37712)
* refactor: 💡 rewrite enzyme tests in react-testing-library

* fix: 🐛 remove enzyme imports from frame-runner.js

* chore: 🤖 install and add enzyme imports to frame-runner.js back
2019-11-08 16:50:25 +05:30
Randell Dawson
5ae8470bd5 fix: changed container to container2 (#37483) 2019-11-07 21:15:38 -05:00
Louisa
2287d73b4f fix missing closing brace and bracket for promise (#37474)
There was a missing closing brace, bracket and semi-colon for the constructor new Promise in its definition
2019-11-07 19:24:54 +01:00
Alex Parra
647945f4ac fix: duplicated 'use' in set-up-passport.english.md (#37134) 2019-11-07 18:42:34 +01:00
Randell Dawson
18891bf3ff feat(curriculum): download solution as non-json text file (#37681)
* feat: download solution as non-json text file

* fix: added missing end of line character

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-07 16:11:57 +05:30
Daniel Veazey
7f4531aed0 replace the word "dashes" with "hyphens" (#37705) 2019-11-07 01:19:39 -05:00
Kiara Barias
3119da3ec5 Changes to "Iterate with JavaScript While Loops - English" challenge description (#37683)
* Update iterate-with-javascript-while-loops.english.md

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-while-loops.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-06 13:26:44 -05:00
PartyLich
a52b5b4ebb feat: rewrite Iterate with JavaScript While Loops challenge (#37697)
* feat: rewrite Iterate with JavaScript While Loops challenge

Previous example in the challenge description was the exact code
that challenge instructions say to implement. Change the challenge to
differentiate from the example.

resolve freeCodeCamp/freeCodeCamp#37694

* fix: update iterate with javascript while loops solution

* refactor: improve iterate with js while loops challenge wording

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-06 12:51:59 -05:00
Kishore Devaraj
06277c8436 fix(client): Improve client validation accessibility (#37459) 2019-11-06 19:43:58 +05:30
Nirvin M
699ffc5593 fix(client): reduce height of the alert banner (#37497) 2019-11-05 21:23:35 +05:30
mrugesh
9be55a3737
docs: update i18n f.a.q about docs and curriculum 2019-11-05 20:54:38 +05:30
mrugesh
cc16f68d0c
docs: update i18n f.a.q about curriculum (#37692) 2019-11-05 20:47:41 +05:30
Randell Dawson
b21ad80563 fix: use jest --rootDir to run test (#37680)
* fix: use bash -c to call jest utils for windows

* fix: removed bash requirement

Co-Authored-By: Valeriy <ValeraS@users.noreply.github.com>
2019-11-05 16:29:33 +03:00
mrugesh
cb5369a582
docs: update devops with password guidelines 2019-11-05 15:54:24 +05:30
Ananda Umamil
734b794714 fix: update react proptypes lesson description (#37477) 2019-11-05 00:42:07 -05:00
Bernardo Sequeira
add5e53020 Fixed Automatic Translation of JS Keywords (#37532) 2019-11-04 12:33:30 -05:00
Bernardo Sequeira
7876b2929b Fixed Automatic Translation of JS Keywords (#37531) 2019-11-04 12:31:54 -05:00
mrugesh
bd1e1e7e73
docs: update devdocs guidelines 2019-11-04 23:01:18 +05:30
Bernardo Sequeira
af71ad2f36 Fixed Automatic Translation of JS Keywords (#37530) 2019-11-04 12:30:00 -05:00
Bernardo Sequeira
250a3727a8 Fixed automatic translation of JS Keywords (#37529) 2019-11-04 11:35:53 -05:00
danielrs975
8389ec1139 Change all ocurrences of the word "matriz" for "arreglo" (#36975)
* Update implement-merge-sort.spanish.md

Change the text "matriz" by "arreglo" that is more accurated

* Change "ordenada" for "ordenado"
2019-11-04 11:24:36 -05:00
Ahmad Abdolsaheb
55a4cadf2a fix: clean failed challenges (#37526) 2019-11-04 19:20:14 +05:30
Parth Parth
c2e7809ccd feat: add message to warn users before changing name (#37527)
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2019-11-04 18:54:18 +05:30
Parth Parth
94340c7b1a docs: update security guidelines to current branch (#37672) 2019-11-04 13:10:27 +05:30
chiaramistro
659b6edf2e fixed typo (#37261) 2019-11-02 13:08:14 +05:30
Roberto Ruccia
36de803902 Fix link in use-proptypes-to-define-the-props-you-expect.english.md (#37665)
* Fix link in use-proptypes-to-define-the-props-you-expect.english.md

* Add a blank line before Note line
2019-11-01 20:22:19 -05:00
mariorguez
4d3aebb7f7 docs: fix Spanish description mixing inline term (#37273)
The Spanish description became difficult to understand due to unnecessary translations of code words (inline, button, etc.).
The final statement for the challenge was also half translated, when it should remain in English to match the tests.
2019-11-01 19:14:15 +01:00
melascuco
c957f5d4f2 Improve challenge description in Spanish (#37040)
Rephrase the challenge description to make it more understandable in Spanish, due to false friends and words order.
2019-11-01 19:06:26 +01:00
bonniepeters
219881c609 docs: update guidelines to mention minutes instead of words (#37603)
* Update CONTRIBUTING.md

This file previously suggested that the code of conduct has 196 words in it when there are in fact 197

* Update CONTRIBUTING.md

Co-Authored-By: mrugesh <1884376+raisedadead@users.noreply.github.com>
2019-11-01 15:01:31 +00:00
Ahmad Abdolsaheb
8f73a92e16 fix: set color based on theme (#37634) 2019-10-31 22:59:47 +05:30
Oliver Eyton-Williams
d8c89c99d8 fix: restrict markdown linting to curriculum files (#37635) 2019-10-31 22:54:07 +05:30