gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2,151 Commits 254 Branches 19 Tags
HexagonalRefactoring
Commit Graph

2151 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Narendra Pathai
37ae182630 Resolved PMD issues 2018-10-15 13:30:20 +05:30
Narendra Pathai
ab2c12e734 1) Refactored LotteryNumbers to use Joiner from guava library to join lottery numbers. 2) Solved potential thread safety issue in LotteryTicketId class, where it was using raw primitive value and incrementing it which is not thread-safe. So used AtomicInteger for brevity 3) assertEquals arguments were in incorrect order at many places, so changed order of those 4) Replaced assertFalse and assertTrue at some places with assertEquals and assertNotEquals for reducing complexity of code 5) Removed public modifiers from test cases, as they are no more needed by JUnit 5 2018-10-15 13:21:00 +05:30
Ilkka Seppälä
db33cc533b Remove CII best practices badge 2018-10-13 18:40:10 +03:00
Ilkka Seppälä
8433c7b712 Merge pull request #793 from andrievsky/master 
Fix redundant list alloc in LotteryNumbers
 2018-10-13 18:28:40 +03:00
Ilkka Seppälä
ee74fec53c Fix pattern title 2018-09-30 21:36:32 +03:00
Ilkka Seppälä
7a7e891384 Set version for next development iteration 2018-09-30 21:05:57 +03:00
Ilkka Seppälä
26d6d96f78 Reach milestone 1.20.0 1.20.0 2018-09-30 21:03:48 +03:00
Ilkka Seppälä
3cec7a9ec1 Merge pull request #796 from LyndonArmitage/module-ignore-test-output 
Delete & Ignore output.txt & error.txt
 2018-09-25 22:49:25 +03:00
Ilkka Seppälä
b079aec1fd Merge pull request #794 from iluwatar/Issue781 
#781 Resolved ClasscastException from Acyclic Visitor
 2018-09-25 22:45:25 +03:00
Lyndon Armitage
8f53df91b9 Delete & Ignore output.txt & error.txt 
Both output.txt and error.txt are produced by tests.
Each file contained a header that was overridden upon executing said
tests causing tracked files to be changed.

Added them to a local .gitignore file for this module.
 2018-09-24 10:08:02 +01:00
Narendra Pathai
709405d964 Resolved checkstyle issues 2018-09-11 16:11:59 +05:30
Narendra Pathai
f3749a2b9d Solved the classcast exception and used instanceof instead. Improved javadocs a bit. 2018-09-11 15:58:14 +05:30
Nick Andrievsky
1d12d94bac Fix redundant list alloc in LotteryNumbers 2018-09-11 11:55:53 +02:00
Narendra Pathai
9e56e5cbc1 Merge pull request #791 from er2/executeAroundLambda 
Execute Around - use lambda
 2018-09-09 00:24:42 +05:30
Narendra Pathai
1698b066f3 Merge pull request #767 from nikhilbarar/collection-pipeline 
#564: Collection Pipeline pattern
 2018-09-09 00:21:45 +05:30
nikhilbarar
4ed039d807 Updated UCLS file and PNG image 2018-09-08 20:38:04 +05:30
Eric Riese
ec6d2a8ebe execute around lambda 2018-09-07 22:29:51 -04:00
nikhilbarar
98c3f93e82 Review changes in Test Cases 2018-09-04 20:52:11 +05:30
nikhilbarar
26fbbed62e Typo in Readme 2018-09-01 15:48:36 +05:30
nikhilbarar
0f9089dd62 Typo in Readme 2018-09-01 15:48:07 +05:30
Narendra Pathai
038befea26 Merge pull request #779 from mitchellirvin/bst-iterator 
#778: Binary Search Tree Iterator
 2018-08-30 12:46:13 +05:30
nikhilbarar
9daa3140e4 Category Enum for category of Car 2018-08-29 22:02:17 +05:30
mxi1809
8458e426bc correcting raw types for the item Iterator. 2018-08-29 07:36:52 -04:00
Mitchell Irvin
e6f84f2f41 modified return type of TreasureChestItemIterator's constructor to be Iterator 2018-08-28 07:46:02 -04:00
Narendra Pathai
74f3799eb4 Merge pull request #788 from diffblue-assistant/finallyclosetotrywithresources 
Use try-with-resources
 2018-08-28 13:17:16 +05:30
nikhilbarar
b23d8430af Added Missing class 2018-08-26 23:31:03 +05:30
nikhilbarar
cb6b0b3600 Checkstyle Fixes 2018-08-26 23:21:25 +05:30
nikhilbarar
cd44ef3c81 Review Changes 2018-08-26 23:12:33 +05:30
Mitchell Irvin
1c2ddfad54 Refactored App.java to remove duplicate code and elegantly demonstrate each implementation of the Iterator interface. Removed the redundant ItemIterator interface. Added insert() method to TreeNode class to allow for more elegant construction of BSTs. 2018-08-25 18:49:43 -04:00
Diffblue assistant
f36de036f6 Use try-with-resources 
Replace try statements that close a resource in the finally block with a
try-with-resources statement [1].

This commit was created automatically by Diffblue refactorings (https://www.diffblue.com/).

[1] https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
 2018-08-23 13:44:55 +01:00
Narendra Pathai
b64262303a Merge pull request #787 from bordoisila1/checkstyle-minor-updates 
Fixed minor changes suggested by Checkstyle
 2018-08-21 11:20:16 +05:30
Narendra Pathai
9d012772fd Merge pull request #785 from sgyyz/fix-image-name 
Fix converter image Display Issue
 2018-08-21 11:12:40 +05:30
bordoisila1
e1a2f141c5 Fixed minor changes suggested by Checkstyle 2018-08-20 22:36:58 -04:00
Yongzhi Yang
cce104a271 Fix converter image issue 2018-08-20 21:14:16 +08:00
Ilkka Seppälä
16df157181 Add license headers 2018-08-13 08:13:06 +03:00
Ilkka Seppälä
c34004bea5 Merge pull request #763 from 7agustibm/master 
First proposal for #586 Hexagonal Architecture primary ports should have interfaces
 2018-08-10 22:42:09 +03:00
Mitchell Irvin
3e0cfa5684 #778 Implemented BSTIterator. Included comprehensive unit and integration tests. Refactored file structure to be friendly to future contributors with iterators of more data structures. Added JUnitPlatform to enable running test suite across all iterator implementations. Added README to /binarysearchtree to document what it does and how it works. 2018-08-04 21:59:53 -04:00
nikhilbarar
ce459e8f9f Merge branch 'master' into collection-pipeline 
# Conflicts:
#	pom.xml
 2018-08-02 02:43:47 +05:30
nikhilbarar
535431fac1 Merge branch 'master' of https://github.com/iluwatar/java-design-patterns 2018-08-02 02:30:08 +05:30
Ilkka Seppälä
facb9e51a6 Merge pull request #774 from zenuo/master 
Add an 'Override' annotaion
 2018-08-01 16:02:23 +03:00
zenuo
9eb8c30bcb Add Annotation 'Override' to com.iluwatar.reactor.app.AppClient.TcpLoggingClient.run method. 2018-07-18 17:06:19 +08:00
nikhilbarar
fc87f8b7d3 Merge branch 'master' of https://github.com/iluwatar/java-design-patterns 
# Conflicts:
#	pom.xml
 2018-07-08 23:09:55 +05:30
Agustí Becerra Milà
b453753790 Fix import not used 2018-07-08 19:38:54 +02:00
Agustí Becerra Milà
d2b900b524 Fix checkstyle & update interface services 2018-07-08 19:25:42 +02:00
nikhilbarar
2c8d1744df #564: Collection Pipeline pattern 2018-07-08 21:37:30 +05:30
Ilkka Seppälä
d915b66e70 Merge pull request #755 from okinskas/ambassador 
Ambassador Pattern #722
 2018-07-08 09:55:36 +03:00
nikhilbarar
328f917749 #564: Collection Pipeline pattern 2018-07-02 00:42:04 +05:30
Agustí Becerra Milà
ae07423470 First proposal 2018-07-01 16:29:07 +02:00
Ovidijus Okinskas
7add7b833c Merge branch 'master' into ambassador 2018-06-29 14:34:31 +01:00
Narendra Pathai
c7f9266768 Merge pull request #753 from Argyro-Sioziou/master 
Acyclic Visitor pattern #734
 2018-06-28 13:55:32 +05:30