68 Commits

Author SHA1 Message Date
Ilkka Seppälä
55b0341c8d Fix remaining Checkstyle errors for Singleton 2019-10-31 20:01:39 +02:00
Leonóra Dér
3b1a28149b decrease number of checkstyle errors in singleton, strategy and visitor patterns #1021 (#1054)
* fix checkstlye errors - visitor pattern

* fix checkstlye errors - strategy pattern

* fix checkstlye errors - singleton pattern
2019-10-31 19:54:13 +02:00
GVSharma
0b8d78e4bf local variable type inference changes (#1036)
local variable type inference changes for design pattern singleton
2019-10-26 18:40:14 +03:00
Alexander Ivanov
4904d7eea0 #1021: Fix checkstyle warnings by changing the license header template (#1027)
* Add custom license header style in order to comply with Google's Checkstyle format

* Update license headers to comply with Google's Checkstyle format
2019-10-22 08:15:35 +03:00
Ilkka Seppälä
9ebbc421dd Update license headers 2019-10-12 20:05:54 +03:00
Adrian Yao
f1410337b5 Fix issue #761: ThreadSafeDoubleCheckLocking.java: Instantiating by Reflection call will be successful if you do that firstly (#920) 2019-09-07 21:13:15 +03:00
baislsl
991ba320a6 Improve Javadoc 2018-02-19 22:01:14 +08:00
Ilkka Seppälä
f9f93695fe
Merge pull request #609 from igorcadelima/master
Protect against instantiation via reflection
2018-02-17 20:36:40 +02:00
Zafar Khaydarov
dddfb52c70
Update EnumIvoryTower.java 2018-01-23 00:07:11 -05:00
Artur Mogozov
6694d742a3 Migrate to JUnit5 2017-12-31 16:29:48 +09:00
Igor C. A. de Lima
3c6f7aa046 Protect against instantiation via reflection
Signed-off-by: Igor C. A. de Lima <igorcadelima@gmail.com>
2017-08-12 12:11:10 -03:00
shaiktaj
24f258848c Updated ThreadSafeLazyLoadedivoryTower
Added null check in private constructor to prevent instantiating by Reflection call
2017-05-25 11:04:30 -05:00
Mudit Porwal
09585c3874 Removed AvoidStarImport Rule
Added JavaDocType Rule
2017-03-22 01:16:02 +08:00
leogtzr
c6d0d28557 Reverting initialization on demand holder idiom. 2017-01-22 11:06:57 -07:00
leogtzr
20b1c2bd49 Adding initialization on demand holder idiom. 2016-12-24 00:49:46 -07:00
Ilkka Seppälä
faa29f8025 Update license headers 2016-11-27 14:34:20 +02:00
daniel-bryla
0438811489 #502 Replaced usages of System.out with logger. 2016-10-23 19:59:03 +02:00
Alexandru Somai
095adda7e9 Change access level to private 2016-08-26 12:54:20 +03:00
Alexandru Somai
f16ae08bdf Remove extra space 2016-08-26 12:46:30 +03:00
Narendra Pathai
d484e7f731 Documented singleton double check idiom, explaining the dynamics that happen on each step for better understanding. Did this due to a PR #475 2016-08-05 14:38:25 +05:30
Sumit Yadav
94c3a2caf3 removed extra "is" from the javadoc of InitializingOnDemandHolderIdiom class 2016-08-03 15:02:46 +05:30
Ilkka Seppälä
2ed3748c9b Improve Singleton holder example 2016-05-07 11:38:55 +03:00
Narendra Pathai
dfef28e93e Merge pull request #384 from DevFactory/release/Redundant-Field-Initializer-fix-1
pmd:RedundantFieldInitializer - Redundant-Field-Initializer
2016-02-18 12:39:06 +05:30
Mohammed Ezzat
0003c6cb00 pmd:RedundantFieldInitializer - Redundant-Field-Initializer 2016-02-18 08:40:19 +02:00
Mohammed Ezzat
632174b6dc squid:S2974 - Classes without public constructors should be final 2016-02-09 17:19:31 +02:00
Joseph McCarthy
3d95696078 #358 Added license to all files using plugin 2016-01-27 22:20:42 +00:00
Jeroen Meulemeester
d0cdf84936 Added tests for singleton pattern 2015-12-30 20:55:21 +01:00
Ilkka Seppala
5f033be54f Fix PMD violations #327 2015-12-27 21:21:57 +02:00
Ilkka Seppala
cec9a99410 Adjust checkstyle rules. Make checkstyle fail the build when violations are found. Correct all current checkstyle violations. 2015-12-25 23:49:28 +02:00
Ankur Kaushal
306b1f3d31 Reformat rest of the design patterns - Issue #224 2015-11-01 21:29:13 -05:00
Richard Jones
7ab799c452 Synchronise the list as multiple threads are calling it 2015-10-13 21:23:32 -03:00
Richard Jones
5d970438bf Update comment 2015-10-12 05:22:09 -03:00
Richard Jones
0d068a35d8 Update comment 2015-10-12 05:21:33 -03:00
Richard Jones
31e2940eb1 Remove error unit test so pull request can proceed. Will check this at at later date 2015-10-11 22:11:03 -03:00
Richard Jones
0107b24976 Fix unit test by makinig getField use the field name directly 2015-10-11 22:06:00 -03:00
Richard Jones
45b0ac386e Add additional unit tests to show that singletons can be created in single thread environment and multithread environment. Also add a test to demonstrate a whole with Singleton when instantiating using reflection
Add some logging. Tests pass locally but not on github?
2015-10-11 21:54:45 -03:00
Richard Jones
6ba7f5ea04 Add additional unit tests to show that singletons can be created in single thread environment and multithread environment. Also add a test to demonstrate a whole with Singleton when instantiating using reflection 2015-10-11 21:32:51 -03:00
Ilkka Seppala
6413c4d2be Added more Singleton documentation #188 2015-10-02 22:53:41 +03:00
zafarella
60f9b71278 eliminate all warnings of checkstyle. 2015-09-24 13:29:39 -04:00
zafarella
36809537d9 checkstyle fixes - docs, indent etc 2015-09-24 01:01:51 -04:00
Ilkka Seppala
4bf2e3f16d #107 JavaDoc for Singleton 2015-08-21 23:09:51 +03:00
Ilkka Seppala
96241f63d2 #100 Added test case for demonstrating the thread safety issues of a
naive lazy loaded Singleton implementation.
2015-07-09 10:36:33 +03:00
Ilkka Seppala
8524c75ba6 Changed package naming across all examples. 2015-05-31 11:55:18 +03:00
mbirkenkamp
649b14adf6 Update App.java
additional explanation about the risks of using the singleton pattern, as requested by @iluwatar
2015-03-14 16:59:02 +01:00
mbirkenkamp
fe625c45be Update App.java
it is important to note that the singleton pattern is inherently unsafe for distributed environments, since the initialization state is not mirrored across different instances of the java vm
2015-03-14 13:48:02 +01:00
Ilkka Seppala
6301e0bc11 Added unit tests for each of the patterns. 2014-12-06 20:34:41 +02:00
Ilkka Seppala
5646937d52 Merge branch 'master' of https://github.com/mortezaadi/java-design-patterns into mortezaadi-master
Conflicts:
	singleton/src/main/java/com/iluwatar/App.java
2014-12-05 22:58:09 +02:00
mortezaadi
c06c05757e add some references to class comments 2014-12-05 11:59:41 +03:30
mortezaadi
dbc1ca7aeb Add DCL and Initializing on demand holder idiom. 2014-12-05 00:02:50 +03:30
Ilkka Seppala
470f3d2460 Added comments to singleton app. 2014-11-26 22:47:44 +02:00