9669e39b85
fix(learn): make tests and test descriptions more explicit ( #41281 )
...
* fix: make tests and descriptions more explicit
* fix: add example to description
* fix: replace pre tags with markdown
* fix: move test data to seed code for convenience
* fix: correct grammar from review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* Revert "fix: move test data to seed code for convenience"
This reverts commit 7a9c4723d6nhcarrigan@gmail.com >
2021-03-12 07:29:03 -08:00
33bd4fb2c4
fix(learn): Change Codepen template link ( #41440 )
2021-03-12 10:41:48 +05:30
53d372c298
fix: update challenge for crowdin in anchor page ( #41450 )
2021-03-11 13:35:34 -07:00
5589c37804
fix(learn): remove wrong spaces and make quotes consistent ( #41434 )
...
* Remove spaces that are not meant to be there (L37, L134, L156) Makes quotes consistent (L61)
Remove spaces that are not meant to be there (L37, L134, L156)
Makes quotes consistent (L61)
* Consistent spacing after commas
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2021-03-11 07:19:07 -08:00
35a8f55515
fix(learn): Remove unnecessary inline code tag in challenge ( #41428 )
...
* remove unnecessary inline code tag
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-less-than-or-equal-to-operator.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* improve challenge wording
* improve challenge wording
* keep wording consistency
* keep wording consistency between similar challenges
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-10 10:16:03 -08:00
5b760e50a3
fix(curriculum) Improved readability and grammar ( #41340 )
...
* fix(curriculum) Improved readability and grammar
* fix missing tags and grammar
* fix(curriculum) changes to grammar
* fix(curriculum) grammar fixes
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-elements-only-visible-to-a-screen-reader-by-using-custom-css.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix(curriculum) Grammar fix
* chore: apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-03-10 09:00:03 -08:00
6b9aeff09e
fix(learn): Rework Euler Problem 461 ( #41333 )
...
* Made instructions more clear + Corrected test cases
* Added highlight for return values
* Adjusted challenge description
* Rework
* Fixed minor linting error
* Address PR Comments
* Adjusted wording in description
2021-03-10 08:14:27 -07:00
d8e6d8dc46
fix(learn): Rework Euler Problem 182 ( #41337 )
...
* Rework Euler Problem 182
* Reordered tests
* Fixes for formatting
2021-03-10 15:55:52 +01:00
256e7f416d
fix(learn): Added more robust logic for the remove test case in Create A Hash Table ( #41283 )
...
* Added extra test cases for hashtable.remove
* Minor Change
* Adjusted tests to use user created add function / Modified description
* Made test case description much more clear
* Changed instructions to be more clear
* Minor change to instructions
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-09 12:45:20 -06:00
18068cdeaa
fix: remove forward slash from <source> tag ( #41422 )
...
The forward slash at the end of the <source> tag in the example is removed, as this is more common.
2021-03-09 16:20:22 +00:00
c5bcebc724
fix(learn): revert backslash change ( #41382 )
...
* fix(learn): revert backslash change
Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.
* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-09 10:13:27 -06:00
bd02249a23
fix(learn): rework Rosetta Code Count the Coins ( #41282 )
...
* fix: rework challenge to use argument in function
* fix: use better wording
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2021-03-09 08:34:10 -06:00
77730ae209
fix(learn): address translator comments ( #41381 )
...
* fix(learn): address translator comments
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/quoting-strings-with-single-quotes.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-09 08:15:26 -06:00
93495ef6db
fix(learn): correct tests description ( #41280 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-09 11:48:12 +05:30
16e420021c
chore: audit data visualisation challenges ( #41336 )
...
* chore(learn): audit d3 projects
* chore: audit data vis
* chore: audit json apis
* Update curriculum/challenges/english/04-data-visualization/data-visualization-projects/visualize-data-with-a-scatterplot-graph.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: apply suggestions
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: no colour backticks
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/get-geolocation-data-to-find-a-users-gps-coordinates.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-05 12:25:29 -07:00
ae79525493
fix(learn): added a missing period and removed single quotes ( #41377 )
...
* Added missing period
On line 24, just before "Note that in your CSS..." a period was missing.
* Removed single quotes and added a missing period
On line 24, just before "Note that in your CSS..." there is a missing period.
On line 30, the text "red-text" within a code tag is enclosed in single quotes.
2021-03-05 07:16:30 -08:00
4d8aae1678
fix: backtick formatting ( #41371 )
2021-03-05 11:39:04 +05:30
5332628e6d
fix(learn): rework Rosetta Code Hailstone Sequence ( #41279 )
...
* fix: rework challenge to use argument in function
* fix: change leftover html to markdown
* Apply suggestions from code review
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
* remove leftovers
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2021-03-04 13:28:47 -08:00
8a5711dda7
Fix: remove a colon in rosetta-code/happy-numbers ( #41349 )
...
* Fix: remove a colon in rosetta-code/happy-numbers
Removed a colon that shouldn't be there
* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/happy-numbers.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Add inline code tags around all true and falses
https://github.com/freeCodeCamp/freeCodeCamp/pull/41349#discussion_r586700058
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-04 09:25:55 -07:00
65cc800689
fix: add blank lines on empty seeds ( #41348 )
2021-03-03 13:14:28 -08:00
728f44ab38
fix: clarify case for already placed valid number ( #41225 )
2021-03-03 23:02:51 +05:30
7117919d36
chore(learn): audit javascript algorithms and data structures ( #41092 )
...
* chore(learn): audit basic algorithm scripting
* chore(learn): audit basic data structures
* chore(learn): audit basic javascript
* chore(learn): audit debugging
* chore(learn): audit es6
* chore(learn): audit functional programming
* chore(learn): audit intermidate algorithms
* chore(learn): audit js projects
* chore(learn): audit object oriented programming
* chore(learn): audit regex
* fix(learn): remove stray .
* fix(learn): string to code
* fix(learn): missed some
* fix(learn): clarify strings
Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.
* fix: apply suggestions - thanks Randy! :)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: non-suggestion comments
* chore(learn): remove comments from codes
Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.
* fix: Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: revert crowdin fix
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: Apply suggestions from code review
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* chore: change voice
* fix: Christopher Nolan
* fix: expressions would evaluate
* fix: will -> would
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: to work to push
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2021-03-02 17:12:12 -07:00
57f3c80345
fix(learn): Clarify date format expectations for the Date Format challenge ( #41327 )
...
* fix: clarify date format expectations
* chore: apply suggestions from code review
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2021-03-02 15:46:30 -08:00
f328bdb93e
fix(curriculum) fixes for grammar and missing articles ( #41335 )
...
* fix(curriculum) fixes for grammar and missing articles
* Update curriculum/challenges/english/01-responsive-web-design/css-grid/add-gaps-faster-with-grid-gap.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-02 12:27:45 -07:00
051a010798
fix(learn): disallow www link from challenge ( #41275 )
...
This commit disallows www link from "Nest an anchor in a paragraph" challenge.
2021-02-27 02:47:47 +05:30
31bdea63a2
chore(learn): audit front end libraries ( #41179 )
...
* chore(learn): audit bootstrap
* chore(learn): audit FE projects
* chore(learn): audit jQuery
* chore(learn): audit React
* chore(learn): audit react-redux
* chore(learn): audit redux
* chore(learn): audit sass
* fix: apply review suggestions
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: apply non-suggestions
* chore: remove comments from code
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-25 10:19:24 -07:00
33356e403a
fix(learn): Use backticks around back slash character ( #41254 )
2021-02-25 16:34:40 +05:30
4917e59aaa
fix(curriculum): use user's url in url shortner tests ( #41257 )
...
This service is both guaranteed to be up (they're hosting it) and should
allow CORS for all requests (including the tests).
2021-02-25 12:04:09 +01:00
b11dd87047
fix: remove sentence not needed ( #41235 )
2021-02-23 11:21:58 -06:00
f4bbe3f34c
fix(learn): Updated code blocks to help with translation on two challenges ( #41217 )
2021-02-22 11:21:59 +05:30
b12360d4a8
Removed the hint Fixes #41192 ( #41215 )
...
* Removed the hint Fixes #41192
* Removed the blank line as suggested
2021-02-21 13:36:14 -07:00
aa615763af
fixed tests for link to external pages challenge ( #41191 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-21 11:46:00 +05:30
531c3f9997
feat(learn): add project tests ( #41183 )
2021-02-21 10:37:02 +05:30
219339b2ce
fix(learn): rework Project Euler - Problem 58 ( #41188 )
2021-02-20 12:06:32 +05:30
f5a905b7c2
fix(learn): unmangle challenge description ( #41182 )
2021-02-20 12:04:38 +05:30
70c4d82068
fix(learn): correct test result ( #41068 )
2021-02-20 12:04:12 +05:30
c8db838754
fix: correct function call in test description ( #40949 )
2021-02-20 12:03:54 +05:30
a91444d3d4
fix: correct function call in test description ( #40944 )
2021-02-20 12:03:33 +05:30
f08174b5b1
fix(learn): Remove unnecessary inline code tag in challenge ( #41177 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-19 09:44:50 +05:30
fad168b465
fix(learn): fix some code tags, capitalization and punctuation in challenge ( #41161 )
...
* fix some code tags, capitalization and punctuation
Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.
* Remove code tags and capitalize first letter
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* capitalize letter and replace slash
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-18 08:45:12 -07:00
2c1280af65
fix(learn): Improve the clarity on a challenge sentence ( #41154 )
...
* Improve the clarity on a challenge sentence
* add string type and remove double quotes
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-18 08:29:31 -07:00
762775889e
fix: rework Project Euler - Problem 57 ( #40926 )
...
* fix: rework challenge to use argument in function
* fix: add solution
* fix: correct variable name
2021-02-17 11:58:18 -08:00
1fe1371b16
add missing inline-code block ( #41153 )
2021-02-17 11:24:53 -08:00
10aee18748
Remove broken twitter links ( #41152 )
2021-02-17 12:03:57 -07:00
b45406ec9d
fix(learn): Remove repeated definition tag in challenge ( #41151 )
2021-02-17 23:01:42 +05:30
c15c27f474
fix(learn): Added another test to check for invalid characters ( #41144 )
2021-02-17 21:16:07 +05:30
2a2657d36c
fix: update regex for Convert JSON Data to HTML ( #41134 )
...
* fix: updated solution for Convert JSON Data to HTML
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2021-02-16 16:27:47 +00:00
21c7abf584
fix(learn): update challenge for crowdin ( #41089 )
2021-02-16 19:47:40 +05:30
ee6764519d
REMOVED comments ( #41048 )
...
* Added comments
Fixes freeCodeCamp/freeCodeCamp#40903
* remove comments
2021-02-11 09:13:38 -07:00
c9de726d6a
feat: move Repl.it links to first challenge in backend projects ( #40803 )
2021-02-11 14:09:59 +05:30
