891a64fa3d
fix(learn): Remove arrows from test name assertion ( #40467 )
...
* fix: Remove arrows from test name assertion
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: Add note about time span
Adds a note regarding the expectation of the `span` element to wrap the
entire time string when translated, not just the delimiter symbol.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: use correct note syntax
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: remove note syntax
New line was breaking the build, so changing the `note` comment to be
regular text.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-01-20 21:57:32 -07:00
b07394603b
feat(learn): Move metric imperial converter tests ( #40358 )
...
* Move tests to /learn
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Modify test verbiage
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/metric-imperial-converter.md
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/metric-imperial-converter.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: add missing tests
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: Correct inaccurate test text - thx @ShaunSHamilton
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: remove arrow from test name
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
2021-01-20 21:51:57 -07:00
d6e47037de
fix(learn): tests of the for in issue regarding the curly braces ( #40344 )
...
* fix: fix the regex of the test of the challenge
* fix: fix data structure challenge
* fix: fix data structure challenge
* fix:fix the test regex of the challenge
* fix: fix the test regex
2021-01-20 21:50:44 -07:00
8e96fef862
fix(learn): Updated instructions for challenge solution for Reuse Patterns Using Capture Groups ( #40658 )
...
* Grammatically updated the instructions for the challenge
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/reuse-patterns-using-capture-groups.md
Co-authored-by: Eric Leung <eric@erictleung.com >
Co-authored-by: Eric Leung <eric@erictleung.com >
2021-01-20 19:39:23 -08:00
8d8d25e9f2
fix(learn): address escaped backticks ( #40717 )
...
* fix(learn): address escaped backticks
Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash. In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.
This issue came to light due to a bug in the translation flow on
Crowdin.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: EVEN MORE :( :( :(
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: backslash nightmares
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: When you wish upon a *******
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix(curriculum): md error introduced by formatter
* fix(curriculum): remove extra `s
* fix: restore quote symbol
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: Typo
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: apply review changes
Applying review feedback from call with @RandellDawson.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: markdown does weird stuff sometimes
Can't stick backticks together - use code.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2021-01-20 19:01:00 -07:00
5379b04387
fix(learn): Removed note about commented array from sorting algorithm challenges ( #40652 )
2021-01-16 12:00:10 -08:00
594b63bc35
fix(learn): Clarify sudoku solver instructions ( #40604 )
...
* Clarify sudoku solver instructions
* decrease spaces
2021-01-16 11:58:48 -08:00
1f62718f52
fix(docs): Add empty line after HTTP request headers ( #40654 )
2021-01-16 12:58:21 -07:00
a5840f57a4
Update Description of Stern-Brocot Challenge ( #40686 )
...
* fix: update description of target function
* fix: include note about 1 based indexing
2021-01-16 12:57:38 -07:00
bab54ad619
fix(learn): no capital code block ( #40688 )
...
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2021-01-16 12:54:38 -07:00
3ecdfe87d7
Update create-a-form-element.md ( #40720 )
...
Improved wording in Description and Instructions sections
2021-01-16 12:25:13 -07:00
fc976aba74
fix(learn): Change example text in create-a-form-element.md ( #40542 )
...
* Update create-a-form-element.md
Update example. For issue 40523
* Clearer formatting of example
2021-01-16 01:11:47 -08:00
ee1e8abd87
feat(curriculum): restore seed + solution to Chinese ( #40683 )
...
* feat(tools): add seed/solution restore script
* chore(curriculum): remove empty sections' markers
* chore(curriculum): add seed + solution to Chinese
* chore: remove old formatter
* fix: update getChallenges
parse translated challenges separately, without reference to the source
* chore(curriculum): add dashedName to English
* chore(curriculum): add dashedName to Chinese
* refactor: remove unused challenge property 'name'
* fix: relax dashedName requirement
* fix: stray tag
Remove stray `pre` tag from challenge file.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: nhcarrigan <nhcarrigan@gmail.com >
2021-01-12 19:31:00 -07:00
ab222e31e7
an audit for some changes ( #40680 )
2021-01-12 09:31:18 -07:00
9770cd0f81
translated some Chinese curriculum files ( #40531 )
...
* translate task #1 - #4
* add translation of zhang-suen-thinning and markov algorithm
Co-authored-by: S1ngS1ng <liuxing0514@gmail.com >
2021-01-08 11:59:18 -07:00
7de8549e02
fix(learn): Made the Escaping literal quotes channel accept the dot inside the double quotes too ( #40465 )
...
* made valid solution dot inside and dot outside quotes
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escaping-literal-quotes-in-strings.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-12-16 08:07:47 -08:00
036da8cd0c
Fixed seed-contents for react componentDidMount challenge ( #40441 )
2020-12-15 18:19:58 -07:00
582d3ab93f
fix(learn): Headless Browser Tests have incorrect values ( #40330 )
...
* Restructure files
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Realign forum topic ids
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Missed query string numbers
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Test all previous tests
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Fix the semi-colon
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* change test name to match boilerplate change
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2020-12-15 19:17:25 -06:00
a1928ba272
Update the return value of values method in create a set class challenge ( #40450 )
...
* fix #40443
* Fix the solution add method
2020-12-15 18:15:33 -07:00
7c19c82076
[BUG] Able to pass challenge "Basic JavaScript: Initializing Variables with the Assignment Operator" with incorrect answers #40406 ( #40409 )
...
* [BUG] #40406 Fix
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/initializing-variables-with-the-assignment-operator.md
Requested Change.
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
2020-12-15 18:07:36 -07:00
0bd52f8bd1
Feat: add new Markdown parser ( #39800 )
...
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
6c5304980d
fix(learn): type checking and additional test for isBalanced binary search tree ( #40323 )
...
* Update find-the-minimum-and-maximum-height-of-a-binary-search-tree.md
* fixed binary search tree values for balanced tree test
* Apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-26 22:33:45 -06:00
4079a197fe
fix(learn): clarify gradient description ( #40322 )
...
* fix: clarify gradient description
* Apply suggested changes
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-26 22:33:03 -06:00
493880ffaf
feat(learn): add mocha and chai instructions ( #39976 )
...
* feat(learn): add mocha and chai instructions
* test: added one new lesson
* rename added file and add tests
* add meta to prettierignore, fix formatting
* add unit-test numbering
* add examples from boilerplate
Co-authored-by: Randell Dawson <rdawson@onepathtech.com >
* remove code comments, add description
* elaborate test testStrings
Co-authored-by: Randell Dawson <rdawson@onepathtech.com >
2020-11-26 10:05:42 -08:00
f294d9cacc
fix(learn): removed use strict from various challenges ( #40321 )
2020-11-25 15:59:04 -08:00
7ce8c58709
Put value into quotes ( #40172 )
...
* Put value into quotes
It can be missunderstanding that "value" is a string!
* fix: remove quotes from inside code tags
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-25 16:32:14 -06:00
49f6875db5
fix(learn): ES6 Getters + Setters tests ( #40238 )
...
* Strengthen tests
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Improve verbiage
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Add second check to setter test
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2020-11-25 14:22:44 -08:00
ec8b2dc016
feat(learn): Message Board User Stories ( #40219 )
...
* Update verbiage, add instructions
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Remove unit test mention
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Move test descriptions to learn
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* target blank on gh link
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2020-11-25 14:11:38 -08:00
49f2055b98
Move tests to /learn ( #40263 )
...
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-11-25 13:27:22 -08:00
62713f0e10
feat(learn): Move American British Translator tests ( #40265 )
...
* Move tests to /learn
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Replace quotes with code
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2020-11-25 12:10:52 -08:00
c0b9ad6bf2
Move tests to /learn ( #40264 )
...
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2020-11-25 12:06:42 -08:00
b5d5ec5a90
feat(learn): Stock Price Checker user stories ( #40218 )
...
* Adjust user stories, add instructions
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Apply review suggestion
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Move tests to /learn
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
2020-11-25 11:55:03 -06:00
df44da9dc2
fix(challenge): correct terminology and inform of correct array copying ( #40045 )
...
* fix(challenge): correct terminology and inform of correct array copying
* fix(challenge): update text with proposed changes
2020-11-25 08:14:33 -08:00
0b117274d7
fix(learn): enhance exercise tracker user stories ( #39965 )
...
* fix(learn): enhance exercise tracker user stories
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: remove duplication mention of count
* fix: add more tests for user story
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: change single quotes to double quotes
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-25 09:25:01 +00:00
79e3cb51e5
feat(learn): add/remove tests for Imperial-Metric Converter ( #39615 )
...
* Remove Infosoc Tests, Add tests, fix error reporting
* Add capital 'L' for liter requirement, check unit/funct test counts
* Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com >
* Apply suggestions from code review
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2020-11-24 20:19:49 +00:00
5a41edca1a
fix(learn): issue tracker test text error message ( #40301 )
2020-11-24 12:56:41 -06:00
b47487b8b2
fix(learn): Change Node project descriptions to all use same template ( #40266 )
...
* fix/change-node-project-descriptions-to-all-use-same-template
* fix: use correct boilerplate
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* fix: add url to link text
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* fix: add _blank for target attribute
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* fix: add missing single quote
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* fix: remove extra lines
* fix: improved wording of description
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
* fix: move sentence to previous paragraph
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
* fix: move sentence to previous paragraph
* fix: move sentence to previous paragraph
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
2020-11-20 12:02:31 -08:00
9ba94e38b4
fix(learn): isSorted
returning true on empty arrays which passes the test ( #40192 )
...
* bug-fix: isSorted returning true on empty arrays
* sorted order test improvements
2020-11-20 09:51:59 -08:00
bce3d5b372
fix(learn): remove white space for quick fix ( #40231 )
...
* fix(learn): remove white space for quick fix
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-20 09:21:21 +01:00
72b8629ecc
fix(learn): personal library boilerplate links destination ( #40267 )
2020-11-19 14:51:59 -08:00
2c9a900353
fix: added more values to list to improve tests ( #40256 )
2020-11-18 09:38:26 +00:00
c03beb3ca6
Fix tests to allow spaces in "Sass: Create Reusable CSS with Mixins" ( #40230 )
...
* Fix tests to allow spaces. Closes #40212
* Apply suggestions from code review
Remove redundant whitespace from regex
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
2020-11-15 00:14:47 +01:00
1ef49d2c57
fix(learn): add note about tweet button restrictions ( #40118 )
...
* fix: add note about tweet button restrictions
* fix: added target blank and top hint
2020-11-14 11:52:48 +00:00
273f1d1aed
fix(learn): typo in an answer to the Numpy question ( #40227 )
...
* fix: typo in an answer to the Numpy question
* fix: revert typo in Chinese file
2020-11-13 13:52:13 -06:00
5a9680a1a6
feat(learn): Add Tests to Issue Tracker Project, Remove InfoSec Tests ( #39627 )
...
* Feature: Add Tests to Issue Tracker Project
* Refactored User Stories
* Apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* Modify verbiage for #39721
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-12 19:51:09 -08:00
bd593667f6
feat(learn): Add tests to Personal Library ( #39642 )
...
* Resolve Merge Conflict
* Add Instructions, Reformat Description
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md
* Change links to Markdown style
* Apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* Apply suggestions from code review
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Verbiage per #39721
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-11-12 16:13:00 -06:00
f353278905
feat: update description and user stories ( #40217 )
...
* feat: update description and user stories
* feat: add hint from boilerplate
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/file-metadata-microservice.md
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-11 12:32:10 -08:00
135928dc5d
fix(learn): update machine learning project colab links ( #40213 )
...
* fix(learn): update machine learning project colab links
Update current machine learning project Colab links to clone Jupyter notebooks from the boilerplate repos rather than the ones in Google Drive.
* fix(learn): update chinese versions of colab links
2020-11-11 08:56:23 -08:00
5aef8a70c6
Fix(learn): improve timestamp project user stories ( #39961 )
...
* fix(learn): enhance timestamp project user stories
* fix(learn): clarify user stories for timestamp project
* fix: update description area
* fix: update verbiage
* fix: broken tests + add a specific example
* fix: add code highlighting
2020-11-10 15:53:57 -08:00
e8b6a9e5dd
fix(learn): add example declaration for clarity ( #40207 )
...
Variable declaration is added which is used inside the switch case.
2020-11-09 17:09:21 +00:00