6ae3735979
fix: correct tests descriptions ( #40945 )
2021-02-10 17:12:12 +05:30
9f219f3f2b
fix(learn): Fix the public assets folder confusion by giving it its own folder ( #40802 )
...
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-02-10 17:11:40 +05:30
082b269dce
fix(learn): backslashes in description & hint text ( #40801 )
...
Correct example code in description and last hints text to match the last assertion test's actual and expected inputs. The string input with a single backslash throws an unterminated string constant error (single backslash starts a regex). No change to last assertion test as it was written correctly with a double backslash and passing as expected.
2021-02-10 17:10:51 +05:30
f8aa6c04e2
fix(learn): update seed code for D3.js challenge ( #40699 )
...
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Lucas Sorenson <lsorenson@sunsh1n3.com >
2021-02-10 17:06:19 +05:30
0f8449788c
feat(learn): add tests to use a callback function in the sort method ( #40847 )
2021-02-10 17:05:23 +05:30
959fe8323a
fix(learn): mongoose set up instructions ( #40909 )
...
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-02-10 17:04:16 +05:30
51f6077f7b
fix(learn): regex-criminal-in-hunt-challenge ( #40901 )
...
* fix: regex-criminal-in-hunt-challenge
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/find-one-or-more-criminals-in-a-hunt.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-08 06:10:59 -08:00
1c539d07c3
fix(curriculum): remove mention of null from challenge ( #40942 )
...
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
2021-02-08 13:17:32 +05:30
15227a0148
fix(curriculum): helmet install and csp lessons ( #40904 )
2021-02-06 16:36:40 +00:00
167f93df76
fix(learn): Add inline code blocks to for i18n ( #40921 )
2021-02-05 14:16:19 +05:30
1a9b791f29
update(curriculum): explicitise use-the-env-file ( #40898 )
...
* update(curriculum): explicitise use-the-env-file
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-02-04 19:43:18 +01:00
12658d33fc
fix(i18n, learn): more crowdin fixes ( #40905 )
2021-02-04 13:34:44 +05:30
30c923b73d
fix(curriculum): helmet hide-powered-by description ( #40900 )
...
* fix: remove option that isn't usable in new version of helmet
* fix: make text instructional
2021-02-03 23:13:02 +00:00
c21b2a9707
fix(learn): corrected typo ( #40902 )
...
Fixed typo at the end of the 4th paragraph. Changed "Others options include:" to "Other options include:".
2021-02-03 15:11:44 -08:00
ddf495c335
Fix 'wrap' and 'wrap-reverse' definitions. ( #40766 )
...
The definitions for the options 'wrap' and 'wrap-reverse' were slightly wrong as can be seen by applying them to the challenge.
2021-02-03 13:01:43 -06:00
313b345611
fix: correct Rosetta Code Knight's tour solution ( #40830 )
...
* fix: correct answers in tests and descriptions
* fix: replace sample solution for correct one
* fix: missing space
* fix: improve sample solution performance
2021-02-03 12:43:29 -06:00
b0bd3f5549
fix(learn): abstract comments from code ( #40869 )
2021-02-03 22:28:33 +05:30
4d48fb5ce7
fix(learn, i18n): crowdin issues ( #40884 )
...
Resolves a couple of issues with Crowdin parsing.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2021-02-02 14:08:32 -07:00
66b684807c
chore: migrate certs from .markdown to .yml
2021-02-02 09:51:02 +05:30
427444c757
chore(learn): audit files for crowdin ( #40838 )
...
* chore(learn): audit files for crowdin
Audits the challenge text in the Responsive Web Design superblock to
account for words/phrases that should not be translated because they
refer to code.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: remove quotes from code
Removes instances of quoted code blocks, or code blocked quotes.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: additional uncaught quote-codes
Thanks Oliver :)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: so many quotes
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: missing punctuation
Noted in a Crowdin comment.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: remove more quotes
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-01 12:56:07 -07:00
8d60aad97b
feat(curriculum): add extension tests for css-flexbox curriculum modules ( #40473 )
...
* feat(curriculum): add extension tests for css-flexbox curriculum modules
* apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* fix: reorder tests
Moves the test that asserts the presence of the follow button to the
top of the order.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-02-01 07:57:36 -08:00
a37d5f5817
fix(learn): add output type verbiage ( #40589 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-01 19:41:15 +05:30
18e821bcd3
fix: remove clunky sentence ( #40751 )
2021-02-01 19:22:39 +05:30
f63ca27e6a
Fix: corrected the typo ( #40837 )
...
Updated run-functional-tests-using-a-headless-browser.md to correct the typo
2021-02-01 06:52:11 -07:00
22f017caa2
fix(learn): replace single bactick with <code> tag for Crowdin ( #40774 )
2021-02-01 19:09:13 +05:30
5503b54f85
fix(learn): update the return Object.values & solution ( #40451 )
2021-02-01 13:12:54 +05:30
8c22432b17
fix(learn): add period for readability ( #40836 )
2021-01-31 13:57:46 +05:30
3394a654bd
fix(learn): Correct syntax in the code example ( #40811 )
...
Closes #40810
2021-01-27 11:03:22 -08:00
d41630ee19
fix(learn): clarify test description for Use Rest Parameter with Function Parameter ( #40725 )
...
* fix: clarify test description
* fix: improve wording regarding rest parameters syntax
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: improve with better sounding wording
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-01-24 08:30:13 -08:00
d5ad87d915
fix(learn): put test cases under --seed-- and remove them from the solution ( #40755 )
...
* fix: put test cases under --seed--
* fix: put test cases under --seed--
2021-01-21 18:26:06 -08:00
ce3a20e552
fix(learn): change requirements for positive and negative lookaheads ( #40570 )
2021-01-21 15:35:19 -06:00
f2b1d7b147
fix(challenge): Assert arrays contain expected values ( #40693 )
2021-01-21 10:52:52 -08:00
a38922536c
Adding language to code fences and pre to console logs ( #40603 )
...
* added languages to prismjs
* added language to code fences for python for everybody
* multiline pre to python for everybody questions
* multiline pre for data analysis with python
* multiline pre in numpy questions
* single line pre for python for everybody
* single line pre for data analysis with python
* single line pre for numpy
* Revert "multiline pre in numpy questions"
This reverts commit af1a02cdd3
.
* fix unneded escaping
commit suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* Revert "single line pre for numpy"
This reverts commit 5f90981108
.
* revert changes to snippet that have a language
* one last code fence to pre
* Revert "fix unneded escaping
"
This reverts commit 64c84a9213
.
* Revert "single line pre for data analysis with python"
This reverts commit 3bccaff753
.
* Revert "single line pre for python for everybody"
This reverts commit 03a5379062
.
* remove unnecessary escape
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
2021-01-21 12:12:42 -06:00
8e62a243bb
fix(learn): Update demo links ( #40575 )
...
* fix(learn): Replace demo projects
Replaces the Heroku demo project links with the
.rocks demo projects that @moT01 provided.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix(learn): Use correct endpoint
Corrects the API endpoint for the image search
project.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: user stories to align with project + backticks
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com >
2021-01-21 11:09:35 -06:00
0a7aa59d51
fix(learn): Convert response testcase regex handles any variable name ( #40568 )
...
* Update convert response to JSON testcase
Testcase previously required that variable be named exactly "response". Changes will allow variable of any name to be used.
Example: res can now be used and tests still pass.
* Forgot the \ in front of )
2021-01-21 08:54:24 -08:00
8a9f3319c6
fix(learn): Fixed typos in count-backwards-with-a-for-loop.md ( #40478 )
...
* Spelling change in count-backwards-with-a-for-loop
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-01-21 08:44:10 -08:00
a5dceb3e7e
Fixed error when changing the default order of css properties ( #40525 )
...
* Bug with psoitioning
Fixed bug with positioning of background-color` property for Selector `.heart::after`
* Trying new changes
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/create-a-more-complex-shape-using-css-and-html.md
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* Tests passing
Check the regex matching at [Regex101](https://regex101.com/r/GU18ds/4 )
* fixed typo
* applied suggestions
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-01-21 10:17:16 -06:00
062b1cd424
fix: replace h tags ( #40750 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-01-21 13:41:46 +05:30
83e3d93953
fix(learn): Remove strong syntax around code inline code ( #40754 )
2021-01-21 13:40:19 +05:30
e57f32438c
fix(learn): correct LCG equation in description ( #40615 )
...
* fix(learn): correct LCG equation in description
* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* Update curriculum/challenges/chinese/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* Revert LCG equation in Chinese file
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
2021-01-20 22:05:37 -08:00
ef394093f7
fix(learn): removing unnecessary test case for regex challenge ( #40581 )
...
Co-authored-by: Alejandro Soto <alejandro.soto@wundermanthompson.com >
2021-01-20 21:53:04 -08:00
dd4c7e0097
fix(learn): Update text as code for vector-dot-product ( #40460 )
...
* fix: implemented suggestted changes
* fix: correct last test expected return value
* fix: remove slash
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: remove slash
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: add test to return null if more than 2 vectors
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: added correct solution
* fix: removed extra brackets
Co-authored-by: Yuval Levental <yhl3051@rit.edu >
Co-authored-by: Lakshya Baghel <lakshyab.1999@gmail.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Yuval Levental <yhl3051@rit.edu >
2021-01-20 21:23:10 -08:00
fb2e5d81f3
Add line breaks to instructions ( #40425 ) ( #40428 )
...
* feat: add line breaks to instructions (#40425 )
* feat: add punctuation to instructions (#40425 )
2021-01-20 22:19:21 -07:00
570d9ad906
fix: updated JSON string in snippet for Python Web Services ( #40742 )
2021-01-20 22:09:16 -07:00
0b01b73e1f
fix: a typo - TSL certificate ===> TLS certificate ( #40697 )
...
* Fixed a typo
* fix: a typo - TSL certificate ===> TLS certificate
* revert: non-English translations have to adhere to a new policy
2021-01-20 22:08:47 -07:00
0b812c91e3
update task description ( #40586 )
2021-01-20 22:06:51 -07:00
b62cf73116
Correcting type on word error ( #40578 )
...
Bug Fix for #40533
2021-01-20 22:05:42 -07:00
a8230fda57
Added Change this line comment ( #40497 )
2021-01-20 22:03:24 -07:00
3061a5a0eb
Text in Basic Data Structures lesson is better clarified. ( #40492 )
...
* text_changes
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-items-using-splice.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Jagadeesh G <17941713+GJ-16@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
2021-01-20 22:02:37 -07:00
3bdf143fd8
Changed the question to one with no ambiguity ( #40488 )
...
* Changed the question to one with no ambiguity
* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-01-20 22:00:18 -07:00