Commit Graph

46 Commits

Author SHA1 Message Date
dfef28e93e Merge pull request #384 from DevFactory/release/Redundant-Field-Initializer-fix-1
pmd:RedundantFieldInitializer - Redundant-Field-Initializer
2016-02-18 12:39:06 +05:30
0003c6cb00 pmd:RedundantFieldInitializer - Redundant-Field-Initializer 2016-02-18 08:40:19 +02:00
632174b6dc squid:S2974 - Classes without public constructors should be final 2016-02-09 17:19:31 +02:00
3d95696078 #358 Added license to all files using plugin 2016-01-27 22:20:42 +00:00
d0cdf84936 Added tests for singleton pattern 2015-12-30 20:55:21 +01:00
5f033be54f Fix PMD violations #327 2015-12-27 21:21:57 +02:00
cec9a99410 Adjust checkstyle rules. Make checkstyle fail the build when violations are found. Correct all current checkstyle violations. 2015-12-25 23:49:28 +02:00
306b1f3d31 Reformat rest of the design patterns - Issue #224 2015-11-01 21:29:13 -05:00
7ab799c452 Synchronise the list as multiple threads are calling it 2015-10-13 21:23:32 -03:00
5d970438bf Update comment 2015-10-12 05:22:09 -03:00
0d068a35d8 Update comment 2015-10-12 05:21:33 -03:00
31e2940eb1 Remove error unit test so pull request can proceed. Will check this at at later date 2015-10-11 22:11:03 -03:00
0107b24976 Fix unit test by makinig getField use the field name directly 2015-10-11 22:06:00 -03:00
45b0ac386e Add additional unit tests to show that singletons can be created in single thread environment and multithread environment. Also add a test to demonstrate a whole with Singleton when instantiating using reflection
Add some logging. Tests pass locally but not on github?
2015-10-11 21:54:45 -03:00
6ba7f5ea04 Add additional unit tests to show that singletons can be created in single thread environment and multithread environment. Also add a test to demonstrate a whole with Singleton when instantiating using reflection 2015-10-11 21:32:51 -03:00
6413c4d2be Added more Singleton documentation #188 2015-10-02 22:53:41 +03:00
60f9b71278 eliminate all warnings of checkstyle. 2015-09-24 13:29:39 -04:00
36809537d9 checkstyle fixes - docs, indent etc 2015-09-24 01:01:51 -04:00
4bf2e3f16d #107 JavaDoc for Singleton 2015-08-21 23:09:51 +03:00
96241f63d2 #100 Added test case for demonstrating the thread safety issues of a
naive lazy loaded Singleton implementation.
2015-07-09 10:36:33 +03:00
8524c75ba6 Changed package naming across all examples. 2015-05-31 11:55:18 +03:00
649b14adf6 Update App.java
additional explanation about the risks of using the singleton pattern, as requested by @iluwatar
2015-03-14 16:59:02 +01:00
fe625c45be Update App.java
it is important to note that the singleton pattern is inherently unsafe for distributed environments, since the initialization state is not mirrored across different instances of the java vm
2015-03-14 13:48:02 +01:00
6301e0bc11 Added unit tests for each of the patterns. 2014-12-06 20:34:41 +02:00
5646937d52 Merge branch 'master' of https://github.com/mortezaadi/java-design-patterns into mortezaadi-master
Conflicts:
	singleton/src/main/java/com/iluwatar/App.java
2014-12-05 22:58:09 +02:00
c06c05757e add some references to class comments 2014-12-05 11:59:41 +03:30
dbc1ca7aeb Add DCL and Initializing on demand holder idiom. 2014-12-05 00:02:50 +03:30
470f3d2460 Added comments to singleton app. 2014-11-26 22:47:44 +02:00
34bc1de713 Added comments to lazily initialized singleton implementation. 2014-11-26 22:45:47 +02:00
0ad5fbfc5c Added comment to eagerly initialized singleton implementation. 2014-11-26 22:43:08 +02:00
baf177a81e Added book reference to singleton enum implementation. 2014-11-26 22:41:44 +02:00
11a89f85a8 move the SO question URL 2014-11-26 09:15:40 +08:00
16ac983053 change comment 2014-11-25 16:24:32 +08:00
3f2cb22478 remove the getInstance method 2014-11-25 16:10:17 +08:00
406d2e7081 simplified the println 2014-11-24 18:01:44 +08:00
13abf49024 enum approach of singleton 2014-11-24 17:35:52 +08:00
862fd39d11 #12 Added private constructor to ThreadSafeLazyLoadedIvoryTower. 2014-11-05 21:28:48 +02:00
5687976a91 Thread-safe Singleton class
New Singleton class name has renamed to ThreadSafeLazyLoadedIvoryTower
and called it from App.java
2014-10-13 22:15:45 -07:00
cffe592c9c New Singleton class
Thread-safe and lazy loading.
2014-10-13 13:24:18 -07:00
3da9ad5469 Formatted all files to the same standard 2014-10-08 13:42:12 +01:00
bde5b343d0 Just formatting App classes to be like the other class files on the project 2014-10-07 16:23:37 +01:00
d6aed142a7 removed the lazy instantiation from singleton to avoid threading
problems.
2014-09-07 21:21:24 +01:00
3d55749042 Update IvoryTower.java
fixed the issue with class creation.
2014-09-07 00:44:32 +01:00
0509e48d37 Update IvoryTower.java 2014-09-06 23:54:25 +01:00
54b414acb1 Commented singleton example. 2014-08-31 08:42:01 +03:00
72415386fe added singleton sample 2014-08-11 21:43:08 +03:00