The two remaining files were still creating a Random everytime the method
was called. These were missed in the previous commit because the previous
commit had fixed only one of the methods; in other words, there were
multiple methods that were creating the Random object on each call.
* 1011: Added SuppressWarnings for SonarCloud errors
All of these files are causing SonarCloud to report the following error:
Loops should not be infinite
Since these instances all require an infinite loop that will never end,
these warnings should be disabled so that SonarCloud no longer reports
them as error.
The rule is: squid:S2189
* 1011: Made all of the randoms static and final
According to SonarCloud rule: "Random" objects should be reused, randoms
should not be recreated. This commit has taken all of the Randoms and made
them constant variables in the files that are using them.
* Switched to embedded Google checkstyle rules
Moved the configuration out of the execution to make it used in all
executions. Fixes#1016
* #1016: Moved checkstyle configuration back into execution
This refactoring may be better done in a new issue as it may have too
many implication.
* Replaced consoleOutput and failsOnError by failOnViolation
consoleOutput outputs everything while failsOnError just fails the build
but doesn't log the error. failOnViolation fails on a violation and logs
it (logViolationsToConsole defaults to true).
The missing class PreconditionViolationException is contained in
junit-platform-commons which comes in transitively by this JUnit
version. junit-jupiter-api had to be added because
spring-boot-dependencies imports an older version of this dependency.
* Fix issue #761: ThreadSafeDoubleCheckLocking.java: Instantiating by Reflection call will be successful if you do that firstly
* Create leader election module
* Create Interface of Instance and MessageManager
* Create implementations with token ring algorithm
* Change package structure.
Create basic message system.
* Implement heartbeat and heartbeat invoking message system
* Implement election message handler
* Add leader message handler
* Add main entry point
* Add comments
* Update README.md
* Fix checkstyle issue
* Add Unit Tests
* Add Unit Tests
* Add bully leader selection
* Change System.out to log print.
Add MIT license in each file.
* Add More java doc comments
* Add unit test
* Add unit tests
* Add subclass-sandbox
* Add Unit Test
* Add Unit Test
* Fix Typo
* Move dependency into parent pom.xml
* Change local valuable reference to be var
The source directory was not working in the 2019.09 version of Eclipse. The
problem was in the layout of the project: after the src/main/java and
src/test/java, the directory was naed com.iluwatar.pipeline. It should've
been com/iluwatar/pipeline. This follows the hierarchy of all of the other
patterns.
Once these files were moved, the Pipeline project compiled without errors.
* 988: Took out the apache http component from root pom.xml
* 988: Updated the aggregator sub projects to use java.net.http instead of apache
* 988: Updated the api-gateway-service sub projects to use java.net.http instead of apache
* Applied the code style formatter
* #496 Add pipeline module to parent pom ✨
* #496: Add main application class and test for pipeline
* #496: Checkstyle format and add log messages on pipeline stages 🎨
* #496: Fill readme sections of pipeline ✨
* #496: Javadocs and checkstyle formatting 🎨
* #496: Follow PMD checks and add more explanation as block comment on App.java
* #496: Apply requested PR changes by iluwatar 🎨
* #970: Replace log4j usage on commander pattern to Slf4j API 🎨
* #970: Replace log4j usage on dao pattern to Slf4j API 🎨
* #970: Replace log4j usage on data mapper pattern to Slf4j API 🎨
* #970: Remove log4j dependency on data transfer object pom 🔥
* #970: Replace log4j usage on module pattern to Slf4j API 🎨
* #970: Replace log4j usage on serverless pattern to Slf4j API 🎨
This also removes the aws log4j dependency
* #970: Remove unnecessary gitignore line for log4j.xml 🔥
* #970: Remove remaining remnants of log4j 🔥
* #970: Replace System.out logging with appropriate logging methods 🎨
* #970: Replace System.out method references to Logger::info 🎨
* Moved java XML and annotations dependencies to project level instead
of as profiles
* Set compiler language level to 11
* Removed jdk8 from travis build
* Kept java level 8 in naked-objects/dom for datanucleus enhancer, for
now.
* Maven profiles to support jdk 11 builds. #948
Added maven profiles activated by jdk 11, wich will not break java 8 support.
Bumped lombok and datanucleus enhancer as the old versions dont work with 11.
* Fixed PMD issue when building naked-objects
* Fixed the eip modules with xml dependencies.
Previous dependency relaxing commit causes xml libs to go missing from
some modules that actually needed them
* Fix issue #761: ThreadSafeDoubleCheckLocking.java: Instantiating by Reflection call will be successful if you do that firstly
* Create leader election module
* Create Interface of Instance and MessageManager
* Create implementations with token ring algorithm
* Change package structure.
Create basic message system.
* Implement heartbeat and heartbeat invoking message system
* Implement election message handler
* Add leader message handler
* Add main entry point
* Add comments
* Update README.md
* Fix checkstyle issue
* Add Unit Tests
* Add Unit Tests
* Add bully leader selection
* Change System.out to log print.
Add MIT license in each file.
* Add More java doc comments
* Add unit test
* Add unit tests
* #496 Add pipeline module to parent pom ✨
* #496: Add main application class and test for pipeline
* #496: Checkstyle format and add log messages on pipeline stages 🎨
* #496: Fill readme sections of pipeline ✨
* #496: Javadocs and checkstyle formatting 🎨
* #496: Follow PMD checks and add more explanation as block comment on App.java
* #496: Apply requested PR changes by iluwatar 🎨
* Fix for issue #954
Add javax.annotation and java.xml.bind as external maven dependencies
Verified with jdk-11
* Move dependency versions to main pom.xml's dependencyManagement section
* Upgrade maven plugins
* Upgrade maven plugins
Some general code cleanup was necessary due to upgrade of PMD and checkstyle.
Also needed to add Junit 4 as a dependency due to Mockito.timout issue found here:
https://github.com/mockito/mockito/issues/152
