gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
1,855 Commits 254 Branches 19 Tags
f80d903cfffe50a3b8957bb26c391908caca2345
Commit Graph

36 Commits

Author SHA1 Message Date
mahendran.mookkiah
e9579633da #587 SonarQube reports bugs in dao module 2017-09-15 17:39:01 -04:00
mahendran.mookkiah
a1a4088087 As getAll method returns a Stream, we cannot close the involved 
resources (Connection, Statement and resultSet) until the stream is
closed by the consumer. So try-with-resources is not an option as per
sonarqube’s recommendation. But it is still recommended to close
statement and result set. When connection pool used, connection is not
closed when close() called. It is just returned to the pool.

Using //NOSONAR to avoid false blocker issue.
 2017-08-13 10:19:48 -04:00
Mudit Porwal
09585c3874 Removed AvoidStarImport Rule 
Added JavaDocType Rule
 2017-03-22 01:16:02 +08:00
leogtzr
6292690250 Changing constant interface pattern with a Noninstantiable class 2016-12-24 14:49:41 -07:00
Ilkka Seppälä
faa29f8025 Update license headers 2016-11-27 14:34:20 +02:00
Ilkka Seppälä
b72214da2f Fix H2 database path problem 2016-04-12 23:04:37 +03:00
Narendra Pathai
ddbc61b140 Incorporated review changes - 1) Created sql file for central schema 2) 
Changed getById return type to Optional
 2016-03-28 11:55:22 +05:30
Narendra Pathai
3f7ead5ca5 Work on #404, updated class diagram and javadoc. Passed checkstyle checks 2016-03-23 13:13:19 +05:30
Narendra Pathai
fa077c8be9 Work on #404, javadocs and test cases for DB and in memory dao. 2016-03-21 17:55:29 +05:30
Narendra Pathai
448d855809 implemented and added test cases for DB dao. Added dependency of Hierarchical junit runner in parent pom 2016-03-18 16:39:45 +05:30
Narendra Pathai
f6a20c7693 Refactoring changes to DAO pattern. Renamed default dao implementation to InMemory and refined interface 2016-03-16 18:47:07 +05:30
Ilkka Seppälä
bbd769b208 Merge pull request #386 from amitbhoraniya/master 
Dao Pattern : Create object with reference to Interface
 2016-02-20 18:34:47 +02:00
Amit Bhoraniya
b70614efef Creating object with reference to Interface 
In Dao pattern DaoImpl object is created with reference to dao interface.
 2016-02-19 00:10:55 +05:30
Ilkka Seppälä
f08af14555 Merge pull request #364 from DevFactory/release/The-diamond-operator-should-be-used-fix-1 
squid:S2293 - The diamond operator should be used
 2016-02-01 22:26:43 +02:00
Ilkka Seppälä
59c32d3937 Add tests that run the examples 2016-01-31 12:09:09 +02:00
Ilkka Seppälä
dc4f07eb81 Merge pull request #360 from mikulucky/MIT-Source 
Pull Request for adding License Plugin and Generate #358
 2016-01-30 15:10:42 +02:00
Ilkka Seppälä
d24a12a9b2 Merge pull request #359 from DevFactory/release/Local-Variables-should-not-be-declared-and-then-immediately-returned-or-thrown-fix-1 
squid:S1488 - Local Variables should not be declared and then immedia…
 2016-01-30 14:42:05 +02:00
Mohammed Ezzat
409ff027b8 squid:S2293 - The diamond operator should be used 2016-01-29 07:33:34 +02:00
Joseph McCarthy
3d95696078 #358 Added license to all files using plugin 2016-01-27 22:20:42 +00:00
Mohammed Ezzat
4e40cc3888 squid:S1488 - Local Variables should not be declared and then immediately returned or thrown 2016-01-27 02:45:39 +02:00
Mohammed Ezzat
d00bfae5ee pmd:ConsecutiveAppendsShouldReuse - Consecutive Appends Should Reuse 2016-01-26 19:58:45 +02:00
Ilkka Seppala
5f033be54f Fix PMD violations #327 2015-12-27 21:21:57 +02:00
Ilkka Seppala
cec9a99410 Adjust checkstyle rules. Make checkstyle fail the build when violations are found. Correct all current checkstyle violations. 2015-12-25 23:49:28 +02:00
Luigi Cortese
043a610754 log4j.xml relocated due to visibility issues and excluded from generated 
JAR. pom.xml formatted according to coding conventions
 2015-11-13 18:34:10 +01:00
Ilkka Seppälä
fe63c9cec4 Merge pull request #281 from ankurkaushal/master 
Reformat according to google style guide
 2015-11-02 21:39:17 +02:00
Ankur Kaushal
449340bd2b Reformat business-delegate, callback, chain, command, composite, dao, decorator & dependency-injection patterns. 2015-11-01 18:48:43 -05:00
Luigi Cortese
25c1f87d46 Corrected Freddy's second name 2015-11-01 23:15:57 +01:00
Ilkka Seppala
339db2a0bf Merge branch 'master' of https://github.com/themoffster/java-design-patterns into themoffster-master 
Conflicts:
	dao/pom.xml
 2015-10-19 20:44:46 +03:00
Ilkka Seppala
621793ed2d Improved DAO Javadoc 2015-10-03 20:34:15 +03:00
Alan
d0af12b1ee Removed magic number. 2015-09-16 21:32:52 +01:00
Alan
51dca28fe7 Updated unit .equals() and .hashCode() methods 
Formatted code using this formatter:
https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml
Removed argument final declaration on interface
Updated addCustomer logic for cases where the added customer already
exists
 2015-09-14 21:22:33 +01:00
Alan
3da48d970c Inclusion of log4j dependency rather than relying on 
System.out.println() statements.
Added unit tests for doa module.
 2015-09-05 21:54:14 +01:00
Ilkka Seppala
3526d96e37 #107 Dao example JavaDoc 2015-08-18 22:08:18 +03:00
Ilkka Seppala
8524c75ba6 Changed package naming across all examples. 2015-05-31 11:55:18 +03:00
Magesh Khanna Vadivelu
8055b9a414 Documentation change in DAO pattern 
Issue: #53
Signed-off-by: Magesh Khanna Vadivelu <mvadivelu@turn.com>
 2015-05-17 23:09:04 -07:00
Mike Giovenco
58da95b467 Added DAO implementation, modified readme, and added UML diagram 2015-04-15 14:54:02 -05:00